Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a (forgotten) section, amending the latest section 5 reorg #214

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Added a (forgotten) section, amending the latest section 5 reorg #214

merged 1 commit into from
Mar 5, 2020

Conversation

iherman
Copy link
Member

@iherman iherman commented Mar 5, 2020 •
edited by pr-preview bot
Loading

Made a mistake in #212, as pointed out by @peacekeeper in #212 (comment): a section got lost in the reorg. Have put it back.

Preview | Diff

@iherman iherman added the editorial Editors should update the spec then close label Mar 5, 2020
@iherman iherman mentioned this pull request Mar 5, 2020
Merged
peacekeeper
peacekeeper approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixes a simple mistake introduced by another PR.

@peacekeeper peacekeeper merged commit ad87e73 into master Mar 5, 2020
@iherman iherman mentioned this pull request Mar 6, 2020
Closed
@msporny msporny deleted the forgotten-section-in-reorg branch April 10, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacekeeper peacekeeper peacekeeper approved these changes

@msporny msporny Awaiting requested review from msporny

Assignees
No one assigned
Labels
editorial Editors should update the spec then close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iherman @peacekeeper