-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify dereferencing of the DID fragment based on the media type. #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for that one misspelling.
</li> | ||
</li> | ||
<li>Otherwise, dereference the secondary resource identified by the DID fragment as defined by the media type ([[RFC2046]]) of the primary resource. | ||
For example, if the primary resource is a representation of a DID document with media type <code>application/did+ld+json</code>, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that multiple +
have been disallowed in IETF/IANA media types.
application/ld+json
might be sufficient, here?
For example, if the primary resource is a representation of a DID document with media type <code>application/did+ld+json</code>, then | |
For example, if the primary resource is a representation of a DID document with media type <code>application/ld+json</code>, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed I agree with your comment, but I think it would be better if this gets discussed and fixed first in did-core, and then later in did-resolution, and that we address this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See w3c/did-core#863
Fix originally suggested by @danpape Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
This was discussed during the #did meeting on 12 September 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make the process much more clear and straightforward for readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to the PR (though I agree that we're essentially depending on what the DID Core spec chooses for the DID media type)
This was discussed during the #did meeting on 19 September 2024. View the transcriptDID Resolution PR 88 / 89Simplify dereferencing of the DID fragment based on the media type Wip: I put this on the agenda. We talked about it last week. Should the primary resource be the DID Document? it says 'first you get the DID Document in resolution, then primary resource...' <swcurran> +1 to WIP about primary document markus_sabadello: agree, lets not have a big discussion about the naming of primary and secondary resource. I have been using the terms as introduced in original rfc3936 manu: Fine with 88 being merged. Agree there was confusion with primary and secondary resource. I also found the current spec text clear on that decentralgabe: We will plan on a special topic call for 88 and 80 around this resource discussion |
This was discussed during the did meeting on 17 October 2024. |
Merging after consensus on last DID WG call. |
This removes language about how to dereference a fragment in the case of a
application/did+ld+json
DID document, and instead states that this is defined by the media type.