Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dereferencing of the DID fragment based on the media type. #88

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

peacekeeper
Copy link
Collaborator

This removes language about how to dereference a fragment in the case of a application/did+ld+json DID document, and instead states that this is defined by the media type.

index.html Outdated Show resolved Hide resolved
Copy link

@danpape danpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for that one misspelling.

</li>
</li>
<li>Otherwise, dereference the secondary resource identified by the DID fragment as defined by the media type ([[RFC2046]]) of the primary resource.
For example, if the primary resource is a representation of a DID document with media type <code>application/did+ld+json</code>, then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that multiple + have been disallowed in IETF/IANA media types.

application/ld+json might be sufficient, here?

Suggested change
For example, if the primary resource is a representation of a DID document with media type <code>application/did+ld+json</code>, then
For example, if the primary resource is a representation of a DID document with media type <code>application/ld+json</code>, then

Copy link
Collaborator Author

@peacekeeper peacekeeper Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed I agree with your comment, but I think it would be better if this gets discussed and fixed first in did-core, and then later in did-resolution, and that we address this in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix originally suggested by @danpape

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@pchampin
Copy link
Collaborator

pchampin commented Sep 12, 2024

This was discussed during the #did meeting on 12 September 2024.

Copy link

@mccown mccown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make the process much more clear and straightforward for readers.

Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to the PR (though I agree that we're essentially depending on what the DID Core spec chooses for the DID media type)

@pchampin
Copy link
Collaborator

This was discussed during the #did meeting on 19 September 2024.

View the transcript

DID Resolution PR 88 / 89

"w3c/did-resolution#88

w3c/did-resolution#89"

Simplify dereferencing of the DID fragment based on the media type

Wip: I put this on the agenda. We talked about it last week. Should the primary resource be the DID Document? it says 'first you get the DID Document in resolution, then primary resource...'

<swcurran> +1 to WIP about primary document

markus_sabadello: agree, lets not have a big discussion about the naming of primary and secondary resource. I have been using the terms as introduced in original rfc3936
… PR 88 is an attempt to remove language related to processing the fragment. This depends on the media type
… Currently the text is specific to a JSONLD document. The intent of the PR is to simplify and remove this part
… regarding the discussion of primary and secondary resource lets have a special topic about it. It effects a lot of things

manu: Fine with 88 being merged. Agree there was confusion with primary and secondary resource. I also found the current spec text clear on that
… not blocking 88

decentralgabe: We will plan on a special topic call for 88 and 80 around this resource discussion


@pchampin
Copy link
Collaborator

This was discussed during the did meeting on 17 October 2024.

View the transcript

w3c/did-resolution#88

markus_sabadello: I can merge this, right?

Wip: Yes.


@peacekeeper
Copy link
Collaborator Author

Merging after consensus on last DID WG call.

@peacekeeper peacekeeper merged commit 34e0786 into gh-pages Oct 24, 2024
1 check passed
@peacekeeper peacekeeper deleted the peacekeeper-dereference-fragment branch October 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants