-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and fix resource explanations #2101
Conversation
…esources # Conflicts: # epub33/core/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit that I originally had a slightly different mental model for the resources than this "axes" view. I have tried to make a diagram for a categorization of resources in
https://docs.google.com/drawings/d/1HFke3nLDSOmZZtjwV38SFrNbA_omRtTgafK51PmEsWA/edit
where the issues around manifest storage or fallbacks appear as "characterizations" of the various resource types. I am just throwing this into the discussion, because I am still not 100% convinced that this "axes" view is the more readable...
There a few problems with your view:
I understand what you're trying to achieve by coaxing the core media types and foreign resources beyond their defined uses, but it doesn't work. There aren't neat lines because a single resource can, for example, be both a Foreign Content Document and Core Media Type depending on the context in which it is used. |
Co-authored-by: Ivan Herman <ivan@w3.org>
Co-authored-by: Ivan Herman <ivan@w3.org>
Co-authored-by: Ivan Herman <ivan@w3.org>
Co-authored-by: Ivan Herman <ivan@w3.org>
Co-authored-by: Ivan Herman <ivan@w3.org>
Co-authored-by: Ivan Herman <ivan@w3.org>
I guess this comment is kind of moot if we agree about axes. Maybe I should have read the full review first... |
I think we agree on those. Not sure whether to use the term "facet" or "axis", though. I leave that choice to you. |
…pecs into restructure/resources
…esources # Conflicts: # epub33/core/index.html
You're jumping in before I'm done rewriting... ;) I'm actually still pondering some things, like the names of the axes. I had trouble making "manifest axis" work because listing in the manifest is more a byproduct of the type of resource. You could equally call it a "container axis" because the type of resource also gets reflected in whether it is in the container or not. I opted to go with "publication axis" to cover that these are all the possible resources. I also had trouble with "rendering axis" because the spine is also a rendering axis. CMTs and Foreign Resources sort of fall into the subrendering axis of the spine rendering axis. That's why I have it as content document axis right now. These may still change. I'll have a look at the comments you've made, though. |
Co-authored-by: Ivan Herman <ivan@w3.org>
Not critical to this PR, but it might be good to rearrange the sections of the RS to match the core. For some reason, it has Foreign Resources, Remote Resources, and Data URLs before Core Media Types. Also, what still bugs me about manifest fallbacks in section 2 is that all the reading system requirements on their processing are combined into the Manifest section under Package Document Processing. I guess we don't have to exactly parallel the core specification, but that exemplifies the disconnect I have with it. It's all about the mechanism in the package document moreso than about resources themselves. I can live with it if no one else finds it problematic, though. |
To help anyone who wants to review this PR (which would be helpful for a change this size!), here's a recap of what has been updated, with links into the preview. Of note is that this PR does not change the way that you include or use resources in a publication, the manifest, or the spine. It's all about better explaining why we have all the classes and what their uses are.
Everything else is just linking cleanup, rewordings to use the new terminology, and various minor fixes where we were using the wrong terms to explain concepts. |
@dauwhe @wareid @shiestyle we would really need extra eyes on this PR. It may be worth adding it on the agenda of this week's call, too. |
Co-authored-by: Ivan Herman <ivan@w3.org>
Editorial fixes
When will this issue be closed? I think that this issue deserves discussion in a WG meeting and 1-week review. |
The issue was discussed in a meeting on 2022-03-31 List of resolutions:
View the transcript1. Expand and fix resource explanations (pr epub-specs#2101)See github pull request epub-specs#2101.
Dave Cramer: this is a very comprehensive re-working of how we define and explain publication resources. Matt Garrish: ivan had some diagrams in the PR, and this was also a useful exercise for identifying areas where terminology had gotten kind of wonky. Dave Cramer: I wish I could wipe my memory of epub and start over with this. Matt Garrish: yes, it was a really helpful exercise, and discussing without this was very convoluted. Dave Cramer: yes, I've witnessed confusion because of the lack of terminology. Matt Garrish: we described where remote resources exist in the planes, but they aren't a class unto themselves. Dave Cramer: right, both remote resources and manifest fallbacks need to serve these other roles. Murata Makoto: i've been a bit skeptical about the publication resources. Now we have a class of linked resources and publication resources. Matt Garrish: yes. Murata Makoto: so rendering means not just visual rendering, but any sort of rendering. Matt Garrish: publication resources are just the big giant bucket of everything used in rendering the epub, c.f. linked resources which are not directly part of the publication. Dave Cramer: ancillary to the publication. Murata Makoto: wondering if we really need the term publication resources, maybe just resource, or resources which are not linked. Matt Garrish: yeah, but then aren't we just going back to not have a direct term for it? would it conflict with other contexts where people talk about resources?. Murata Makoto: so you are saying resources within the zip file are one category, and that resources outside the zip file are something else. Matt Garrish: resources is just a very general term, so i'm worried that it becomes too broad. Dave Cramer: resources as a term is so overloaded, i don't think it gains us clarity. Murata Makoto: not happy with the definition of publication resources because it depends on rendering, which is not well defined in itself. Dave Cramer: i think we're clear that rendering is anything presented to the user. Murata Makoto: is that in the spec?. Dave Cramer: i think it's a term of art in the web/graphics world. Murata Makoto: before i got involved in a11y, i never thought of braille as rendering. Matt Garrish: it's still presented to the user. Murata Makoto: how about adding a note on the scope of rendering?. Matt Garrish: that's fine with me, not sure where it would fit, but we could do this. Dave Cramer: maybe in the terminology section?. Matt Garrish: we could make a defined term out of it, like 'encompasses all the ways content may be presented, whether visual, tactile, or auditory'. Dave Cramer: in general i think this is a massive improvement to the legibility of the spec.
Matt Garrish: the bulk of this is informative, so likely nothing normative changes as a result of this.
Murata Makoto: will we close this issue too?.
Dave Cramer: yes, and then we can open more detailed issues on subsets of this. Matt Garrish: there's no actual issue, the PR is based on discussions i had with ivan. Murata Makoto: so nothing wrong with raising smaller issues related to this?. Dave Cramer: yes. Matt Garrish: and it's hard to raise issues off a PR.
Dave Cramer: anyone else, please vote now.
Dave Cramer: mgarrish please merge at your convenience. |
With this PR, I've tried to rationalize all the categories of resources and exemptions we've layered onto the spec.
Probably the biggest addition is to add formal terms for things we've left unnamed:
link
element definition, so it's more a standardization effort.I've also tried to explain how all these resources come together in a new introduction to the Publication Resources section. The groupings generally break down like this:
But there are overlaps and exemptions that make not quite so simple.
I've also gone through and tried to clean up all the inconsistencies that have arisen because we've tended to drop into using the wrong terminology in various places.
From a structural standpoint, this PR gets rid of the "Core Media Types" section and renames the section "Supported Formats" to "Core Media Types", as this is really where we define them. It also moves the Manifest Fallbacks section up into Publication Resources, although I'm still not sure if this is the best location given how heavy it is on explaining the item element.
At any rate, hopefully this helps improve the ambiguities about why core media types are not always fallback exempt, why foreign resources are not the only foreign things in the spine, etc.
It's also a starting point, so if there are other improvements we can make here please feel free to comment.
(The changes so far should not normatively change anything.)
Also fixes #2083
Also fixes #2160
Preview | Diff