Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reading system conformance section #2305

Merged
merged 8 commits into from
May 31, 2022
Merged

Add reading system conformance section #2305

merged 8 commits into from
May 31, 2022

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented May 20, 2022 •
edited
Loading

May be stating the obvious by adding this, but probably better to err on the side of clarity:

  • states that all required and conditionally required features must be met to be conformant
  • for recommended feature, processing can typically be ignored, but not always (e.g., scripting has fallback requirements when not supporting)

Addresses part of #2271 but not going to close that issue automatically.

EPUB Reading Systems 3.3:

dlazin
dlazin approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@dlazin dlazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this; thanks.

epub33/rs/index.html Show resolved Hide resolved
epub33/rs/index.html Outdated Show resolved Hide resolved
@mattgarrish @dlazin
Update epub33/rs/index.html
a2b7071 
Co-authored-by: Dan Lazin <dlazin@users.noreply.github.com>
iherman
iherman approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a nuance that is not necessary to mention, but I raise it anyway...

I

epub33/rs/index.html Outdated Show resolved Hide resolved
@mattgarrish mattgarrish merged commit 8398f82 into main May 31, 2022
@mattgarrish mattgarrish deleted the feature/rs-conformance branch May 31, 2022 10:41
@dlazin dlazin mentioned this pull request Jun 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iherman iherman iherman approved these changes

@dlazin dlazin dlazin approved these changes

@dauwhe dauwhe Awaiting requested review from dauwhe

@shiestyle shiestyle Awaiting requested review from shiestyle

@wareid wareid Awaiting requested review from wareid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattgarrish @iherman @dlazin