feat: check "data-*" attributes name restrictions #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgarrish
reviewed
Jan 3, 2023
| @@ -64,6 +64,7 @@ HTM_058=HTML documents must be encoded in UTF-8, but UTF-16 was detected. | |||
| HTM_059=Viewport "%1$s" property must not be defined more than once, but found values [%2$s]. | |||
| HTM_060a=EPUB reading systems must ignore secondary viewport meta elements in fixed-layout documents; viewport declaration "%1$s" will be ignored. | |||
| HTM_060b=EPUB reading systems must ignore viewport meta elements in reflowable documents; viewport declaration "%1$s" will be ignored. | |||
| HTM_061="%1$s" is not a valid custom data attributes (it must have at least one character after the hyphen, be XML-compatible, and contain no ASCII upper alphas). | |||
There was a problem hiding this comment.
s/attributes/attribute/
I also wonder if "upper alphas" will be clear to general users. Might be safer to be more verbose with "uppercase letters".
Suggested change
| HTM_061="%1$s" is not a valid custom data attributes (it must have at least one character after the hyphen, be XML-compatible, and contain no ASCII upper alphas). | |
| HTM_061="%1$s" is not a valid custom data attribute (it must have at least one character after the hyphen, be XML-compatible, and not contain ASCII uppercase letters). |
mattgarrish
approved these changes
Jan 3, 2023
rdeltour
force-pushed
the
feat/link-vocab
branch
from
ab13ef0
to
6a3d2a6
Compare
According to HTML: > A custom data attribute is an attribute in no namespace whose name > starts with the string "data-", has at least one character after the > hyphen, is XML-compatible, and contains no ASCII upper alphas. This commit reports invalid `data-*` attributes as errors with a new error code, `HTM-061`. This should be ideally delegated to validator.nu, but we add this check until we fully integrate the HTML checker. Close #1107
rdeltour
force-pushed
the
feat/data-attributes
branch
from
aa75f9b
to
22f5994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to HTML:
This commit reports invalid
data-*attributes as errors with a new error code,HTM-061.This should be ideally delegated to validator.nu, but we add this check until we fully integrate the HTML checker.
Close #1107