Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Expose everywhere" #138

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Revert "Expose everywhere" #138

merged 1 commit into from
Sep 20, 2022

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Jul 22, 2022 •
edited by pr-preview bot
Loading

@yoavweiss yoavweiss requested a review from nicjansma July 22, 2022 14:01
@yoavweiss
Copy link
Contributor Author

Happy to re-land this once we have implementation commitments.

@saschanaz
Copy link
Member

This needs to be merged as the current IDL conflicts with w3c/user-timing#93. Performance can't be exposed everywhere without exposing PerformanceMark, and this can cause errors on toolings with IDL.

@yoavweiss yoavweiss merged commit f1fd2aa into gh-pages Sep 20, 2022
@yoavweiss yoavweiss deleted the revert-130-expose-everywhere branch September 20, 2022 13:45
@ptomato ptomato mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicjansma nicjansma nicjansma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoavweiss @saschanaz @nicjansma