Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to "sectioning root" #456

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Jan 24, 2023

Sectioning root was removed from HTML here: whatwg/html#7829
So this PR updates CORE-AAM to match the authors guidance here: https://w3c.github.io/html-aria/#el-header
And we separately discussed that the "sectioning root" check was unnecessary here: #375 (comment)

This doesn't close the issue #375 because scoped is still not defined.

Implementation

  • WPT tests: LINK
  • Implementations (link to issue or when done, link to commit):

Preview | Diff

Copy link
Collaborator

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I don't think this requires a change in WebCore Accessibility, so I don't believe a WebKit bug tracker is required. If we later discover that I was wrong, we can track it then.

@stevefaulkner stevefaulkner merged commit 65891f6 into gh-pages Jan 30, 2023
@scottaohara scottaohara deleted the remove-sectioning-roots branch January 30, 2023 23:08
@scottaohara scottaohara restored the remove-sectioning-roots branch January 31, 2023 20:15
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 31, 2023
Previous to this CL, <aside> was always mapped to a landmark role.
Now, <aside> to landmark role (role=complementary) if:

1) Scoped to main or body elements, or
2) Given accessible name if scoped to sectioning content elements

Additionally, the "sectioning root" concept was removed from html,
therefore <header> and <footer> will only be mapped to a non
landmark role if inside a sectioning content element (main,
aside, navigation, section, article).
See CORE-AAM update: w3c/html-aam#456

Finally, the mapping originally only respected sectioning content
elements according to their html tag, but now they respect the
equivalent ARIA roles as well.

Fixed: 1286298
Change-Id: Iea9a4ce6c7480bbe73896d6bb53b025153215a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508314
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1099511}
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 1, 2023
This is a reland of commit 2f5b28a

Reason for revert: broke accessibility tests on Fuchsia
https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-rel/3640/overview

Original change's description:
> Update <aside>, <header>, <footer> HTML-AAM mapping
>
> Previous to this CL, <aside> was always mapped to a landmark role.
> Now, <aside> to landmark role (role=complementary) if:
>
> 1) Scoped to main or body elements, or
> 2) Given accessible name if scoped to sectioning content elements
>
> Additionally, the "sectioning root" concept was removed from html,
> therefore <header> and <footer> will only be mapped to a non
> landmark role if inside a sectioning content element (main,
> aside, navigation, section, article).
> See CORE-AAM update: w3c/html-aam#456
>
> Finally, the mapping originally only respected sectioning content
> elements according to their html tag, but now they respect the
> equivalent ARIA roles as well.
>
> Fixed: 1286298
> Change-Id: Iea9a4ce6c7480bbe73896d6bb53b025153215a14
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508314
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Valerie Young <spectranaut@igalia.com>
> Cr-Commit-Position: refs/heads/main@{#1099511}

Change-Id: I038a8e9a27ba53bf8075b9c92a4fb53149850f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4213811
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1100028}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants