Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new aria 1.2 roles #392

Merged
merged 13 commits into from
Mar 12, 2022
Merged

add new aria 1.2 roles #392

merged 13 commits into from
Mar 12, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jan 10, 2022

closes #200

Adds blockquote, caption, code, deletion, emphasis, generic, insertion, meter, paragraph, strong, subscript, superscript, time.

Updates links from referencing ARIA 1.1 to ARIA 1.2

changes / corrects dd and dt to not reference an ARIA role, as definition and term were corrected in ARIA 1.2 to not be associated with these elements.

These are non-normative updates, since these roles are defined in ARIA 1.2/CORE AAM and the HTML mappings in HTML AAM, respectively.

TODO:
more elements map to generic. Additionally, there needs to be some content added to the spec to indicate that generic is a role authors SHOULD NOT be using, per the ARIA spec. This could be tacked onto the 'any role' definition (issue to update 'any role' #358).

related to resolving HTML AAM w3c/html-aam#373


Preview | Diff

closes #200

Adds `blockquote`, `caption`, `code`, `deletion`, `emphasis`, `generic`, `insertion`, `meter`, `paragraph`, `strong`, `subscript`, `superscript`, `time`.

Updates links from referencing ARIA 1.1 to ARIA 1.2

changes / corrects `dd` and `dt` to not reference an ARIA role, as `definition` and `term` were corrected in ARIA 1.2 to not be associated with these elements.

TODO:
more elements map to `generic`.  

These are non-normative updates, since these roles are defined in ARIA 1.2/CORE AAM and the HTML mappings in HTML AAM, respectively.
@scottaohara scottaohara added the Do not merge A PR which needs additional work or question resolved before it can be merged. label Jan 10, 2022
@scottaohara
Copy link
Member Author

Waiting on merging of w3c/html-aam#364 before finishing this PR

@scottaohara scottaohara added blocked An issue that cannot be resolved due to other external requirements and removed Do not merge A PR which needs additional work or question resolved before it can be merged. labels Feb 8, 2022
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes/questions - see comments (not sure why it's now marking them as outdated...unless i've commented on some previous state/github wasn't showing me the latest, not sure)

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged, but worth opening a separate PR to have another look at that role=Main issue (as if it's making a point about lowercase, it buries the lede/doesn't actually explain it)

@scottaohara
Copy link
Member Author

scottaohara commented Mar 12, 2022

The only thing that will be out of sync with merging this PR is the dt and dl mappings in comparison with HTML AAM. w3c/html-aam#373 will cover that. Since only those 2 elements won't be accurate until that AAM pr is merged, I think it's probably fine to pull this in now. I'm going to create a new issue regarding the other elements which still need updates per the TODO in the op.

@scottaohara scottaohara removed the blocked An issue that cannot be resolved due to other external requirements label Mar 12, 2022
@scottaohara scottaohara merged commit d3b0ff0 into gh-pages Mar 12, 2022
@scottaohara scottaohara deleted the add-aria12-roles branch March 12, 2022 17:38
estelle pushed a commit to mdn/content that referenced this pull request Oct 14, 2023
* Set implicit role mappings to `generic`

Implements changes from w3c/html-aria#425

* Set address' element implicit role to `group`

Implements change from w3c/html-aria@ba30b83

* Assign ARIA 1.2 roles to elements

Implements changes from w3c/html-aria#392

* Make `<section>` with inaccessible name's implicit role to be `generic`

See w3c/html-aria#475

* Set implicit ARIA mapping for <s> element to `deletion`

See w3c/html-aria#469

* Set `form` as the only implicit ARIA role for the form element

See w3c/html-aria#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new ARIA roles
3 participants