Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Cleanup Embedded content section #1176

Closed
agcolom opened this issue Feb 1, 2018 · 5 comments
Closed

Cleanup Embedded content section #1176

agcolom opened this issue Feb 1, 2018 · 5 comments
Assignees

Comments

@agcolom
Copy link
Member

agcolom commented Feb 1, 2018

<pre highlight="html">
&lt;table&gt;
&lt;tr&gt;&lt;tr&gt; &lt;th&gt; Image &lt;th&gt; Description&lt;tr&gt;
&lt;td&gt;
&lt;figure&gt;
&lt;img src="2421.png"&gt;
&lt;figcaption&gt;Image 640 by 100, filename 'banner.gif'&lt;/figcaption&gt;
&lt;/figure&gt;
&lt;td&gt; &lt;input name="alt2421"&gt;
&lt;tr&gt;
&lt;td&gt; &lt;figure&gt;
&lt;img src="2422.png"&gt;
&lt;figcaption&gt;Image 200 by 480, filename 'ad3.gif'&lt;/figcaption&gt;
&lt;/figure&gt;
&lt;td&gt; &lt;input name="alt2422"&gt;
&lt;/table&gt;
</pre>

I'm finding this example hard to read... and I think there might be an extra <tr> at the start (L3253) which should be removed?

Would it be ok to either add the omitted closing tags and/or indent the code and avoid having an opening <tr> at the end of a line ((L3253)?

I'd be happy to submit a PR if you let me know

  1. whether the extra <tr> at the start should be removed
  2. whether we add the omitted closing tags (I'm ok either way)
  3. whether it is ok to indent the code
  4. whether it is ok to move the end of line <tr> on a new line.

Thank you

@chaals
Copy link
Collaborator

chaals commented Feb 1, 2018

It would be nice to make the formatting more regular so people can understand the example more easily. So the answer to all your questions is "yes". (For this and almost any other example, except where they are explicitly to show that different syntax makes the same result)

I think this whole section is pretty problematic, and would suggest basically starting from scratch, which you may want to do instead...

@agcolom
Copy link
Member Author

agcolom commented Feb 1, 2018

@chaals brilliant! I'll get started and I'll send a PR when ready. We can then add to the PR after review etc. I will assign to myself for now, and I'll add comments here if I have further questions on this section :-)

@agcolom agcolom self-assigned this Feb 1, 2018
@agcolom agcolom changed the title Hard to read example Cleanup Embedded content section Feb 2, 2018
@agcolom
Copy link
Member Author

agcolom commented Feb 2, 2018

Changed the issue name to better reflect the task.

edent added a commit that referenced this issue Feb 4, 2018
* Better layout
* Alt Text
* Fixes #1176 ? Possibly

Fixes #1182
edent added a commit that referenced this issue Feb 4, 2018
* Fixes #1176
* Remove unnecessary bitly link
* More cleanup

Fixes #1182
@chaals
Copy link
Collaborator

chaals commented Feb 13, 2018

@agcolom does #1199 cover this, or do you want to leave it open?

I think if you do leave it open, a more specific explanation of the issue would be helpful.

@agcolom
Copy link
Member Author

agcolom commented Feb 13, 2018

@chaals It looks like @edent 's work has addressed this issue 👍 Thank you! I'll close the issue.

@agcolom agcolom closed this as completed Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants