Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor proofreading edits, 11/07/2024 #516

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

dginev
Copy link
Contributor

@dginev dginev commented Nov 7, 2024

This PR is not related to active action items.
It contains misc edits from proofreading that are not meant to introduce any changes:

  • consistent descendant spelling
  • removed an extra used by
  • changed AT's to supported
  • added speech part to the example for underscore function use
  • (I think?) clearer word order on concept addition/removal
  • dropped dash from unannotated

If some of these are not useful, feel free to cherrypick anything of interest and close here.

Copy link
Collaborator

@davidcarlisle davidcarlisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on a couple of changes don't seem quite right, all the others look good thanks

@@ -526,6 +526,7 @@ <h3 id="mixing_intent_examples">Intent Examples</h3>
&lt;mo arg="script">&#x2032;&lt;/mo>
&lt;/msup>
</pre>
<blockquote>x prime<br/>x superscript prime end superscript</blockquote>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just have x prime (which I just checked also matched what mathcat does) I don't see how you can get x superscript prime as the intent masks the presentation so you are explicitly stoping the "superscript" being read (if you are using the intent at all) The system may of course have an option to read the underlying markup ignoring intent but that shouldn't be in this "intent examples" section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, exactly, when the intent is used it is x prime. That's the starting fragment before the <br/>.

The second entry is the speech when intent isn't used - I copied it directly from the example right above, there are several that follow that pattern.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they do? I'll look again when it's not midnight, as I say wasn't planning on rushing any edits:-)

src/intent.html Outdated Show resolved Hide resolved
@davidcarlisle
Copy link
Collaborator

If some of these are not useful, feel free to cherrypick anything of interest and close here.
I could do this, thanks but I'll leave it for a bit for others to comment, Probably at the weekend...

@davidcarlisle
Copy link
Collaborator

actually I think you are right and I did say that (but I think I was wrong in the meeting and it's better as it is) but now it's definitely too late to think about wording

@davidcarlisle
Copy link
Collaborator

@dginev on the readings with and without intent. You are right, not only do the ones above have that style the text above that block of examples (which I guess I wrote, but didn't read) explicitly says that is what they are

These cases would be distinguished as follows, showing possible readings with and without intent

So obviously your addition here is good.

That said I think the example display isn't clear. If you jump to a single example, and you are tired it really isn't clear that the the two line text example is line 1 with intent and line 2 without. I think we should experiment with modifying the format, perhaps having an explicit intent/nointent comment on each. But that doesn't need to be in this PR

@davidcarlisle
Copy link
Collaborator

@dginev thanks for adjusting the branch, there is nothing remotely controversial in the remaining edits so merging now

@davidcarlisle davidcarlisle merged commit a388709 into w3c:main Nov 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants