-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor proofreading edits, 11/07/2024 #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on a couple of changes don't seem quite right, all the others look good thanks
@@ -526,6 +526,7 @@ <h3 id="mixing_intent_examples">Intent Examples</h3> | |||
<mo arg="script">′</mo> | |||
</msup> | |||
</pre> | |||
<blockquote>x prime<br/>x superscript prime end superscript</blockquote> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just have x prime
(which I just checked also matched what mathcat does) I don't see how you can get x superscript prime
as the intent masks the presentation so you are explicitly stoping the "superscript" being read (if you are using the intent at all) The system may of course have an option to read the underlying markup ignoring intent but that shouldn't be in this "intent examples" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, exactly, when the intent is used it is x prime
. That's the starting fragment before the <br/>
.
The second entry is the speech when intent isn't used - I copied it directly from the example right above, there are several that follow that pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they do? I'll look again when it's not midnight, as I say wasn't planning on rushing any edits:-)
|
actually I think you are right and I did say that (but I think I was wrong in the meeting and it's better as it is) but now it's definitely too late to think about wording |
@dginev on the readings with and without intent. You are right, not only do the ones above have that style the text above that block of examples (which I guess I wrote, but didn't read) explicitly says that is what they are
So obviously your addition here is good. That said I think the example display isn't clear. If you jump to a single example, and you are tired it really isn't clear that the the two line text example is line 1 with intent and line 2 without. I think we should experiment with modifying the format, perhaps having an explicit intent/nointent comment on each. But that doesn't need to be in this PR |
@dginev thanks for adjusting the branch, there is nothing remotely controversial in the remaining edits so merging now |
This PR is not related to active action items.
It contains misc edits from proofreading that are not meant to introduce any changes:
descendant
spellingused by
AT's
tosupported
If some of these are not useful, feel free to cherrypick anything of interest and close here.