Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the mechanism for limiting repeated calls to canMakePayments ? #367

Closed
ianbjacobs opened this issue Dec 12, 2016 · 3 comments · Fixed by #380
Closed

What is the mechanism for limiting repeated calls to canMakePayments ? #367

ianbjacobs opened this issue Dec 12, 2016 · 3 comments · Fixed by #380
Assignees
Labels

Comments

@ianbjacobs
Copy link
Collaborator

At our 8 December call [1] we agreed to move forward with some form of canMakePayment and
resolved to separate out the issue of how to limit repeated calls to it.

Ian
[1] https://www.w3.org/2016/12/08-wpwg-minutes.html#item01

domenic added a commit to domenic/browser-payment-api that referenced this issue Dec 14, 2016
This closes w3c#310, and closes w3c#316 (which it is roughly based on), and closes w3c#367 by intentionally allowing user agent leeway in restricting repeated calls to canMakePayment().
zkoch pushed a commit that referenced this issue Dec 14, 2016
This closes #310, and closes #316 (which it is roughly based on), and closes #367 by intentionally allowing user agent leeway in restricting repeated calls to canMakePayment().
@ianbjacobs
Copy link
Collaborator Author

Please don't close this issue yet. We intentionally opened this as a separate issue to continue discussion of the mechanism for rate limiting.

@ianbjacobs ianbjacobs reopened this Dec 15, 2016
@marcoscaceres
Copy link
Member

The spec says:

If the method is called too often, the user agent might instead return a promise rejected with a "QuotaExceededError" DOMException, at its discretion.

@ianbjacobs, is that sufficient? can we close?

@ianbjacobs
Copy link
Collaborator Author

Yes, ok to close. I believe we had consensus to let browsers try different approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants