Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is never stated how the payment request ID is used #415

Closed
domenic opened this issue Feb 8, 2017 · 1 comment
Closed

It is never stated how the payment request ID is used #415

domenic opened this issue Feb 8, 2017 · 1 comment
Assignees
@marcoscaceres @rvm4

Comments

@domenic
Copy link
Collaborator

domenic commented Feb 8, 2017

It appears that it's meant to be (a) set during construction, see #413, then (b) PaymentResponse is supposed to set its paymentRequestID to the same value of the PaymentRequest that generated it.

This latter part (b) never happens in the spec, so it is spec-complaint right now for paymentResponse.paymentRequestID to return anything at all.

"user accepts the payment request algorithm" needs to have a step that copies over the paymentRequestID value.

This should be done after #413 since it looks like #413 is going to introduce an internal slot to hold the paymentRequestID on the PaymentRequest object.
@rvm4 rvm4 mentioned this issue Feb 23, 2017
Merged
marcoscaceres pushed a commit that referenced this issue Mar 6, 2017
@rvm4
feat: put request id in details dictionary (#426)
712e10b 
closes #388, #412, #415.
@marcoscaceres
Copy link
Member

closed via #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoscaceres marcoscaceres

@rvm4 rvm4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @marcoscaceres @rvm4