Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown currencySystem should throw #686

Closed
marcoscaceres opened this issue Feb 20, 2018 · 0 comments · Fixed by #689
Closed

Unknown currencySystem should throw #686

marcoscaceres opened this issue Feb 20, 2018 · 0 comments · Fixed by #689

Comments

@marcoscaceres
Copy link
Member

We have a few instances of things relying on:

If amount.currencySystem is not "urn:iso:std:iso:4217", terminate this algorithm.

via "check and canonicalize amount" and "check and canonicalize total". However, the places that rely on the two aforementioned algorithms are expecting them to throw.

Thus, we should change the spec text to:

If amount.currencySystem is not "urn:iso:std:iso:4217", throw a TypeError.

I'm aware that we are planning on probably ejecting currencySystem from the spec, but this would allow us to test support for it properly... so this change would be for completeness.

marcoscaceres added a commit to web-platform-tests/wpt that referenced this issue Mar 1, 2018
This test is to prove that no one supports this feature - thus can be dropped from the spec. 

Related issues: 
 * w3c/payment-request#686
 * w3c/payment-request#617
@marcoscaceres marcoscaceres self-assigned this Mar 1, 2018
marcoscaceres added a commit to web-platform-tests/wpt that referenced this issue Mar 2, 2018
This test is to prove that no one supports this feature - thus can be dropped from the spec. 

Related issues: 
 * w3c/payment-request#686
 * w3c/payment-request#617
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 1, 2018
…ySystem, a=testonly

Automatic update from web-platform-testsTests for PaymentCurrencyAmount's currencySystem (#9728)

This test is to prove that no one supports this feature - thus can be dropped from the spec.

Related issues:
 * w3c/payment-request#686
 * w3c/payment-request#617

wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
…ySystem, a=testonly

Automatic update from web-platform-testsTests for PaymentCurrencyAmount's currencySystem (#9728)

This test is to prove that no one supports this feature - thus can be dropped from the spec.

Related issues:
 * w3c/payment-request#686
 * w3c/payment-request#617

wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728

UltraBlame original commit: 8532450c23ebb162936f6accdba0a878b744925f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
…ySystem, a=testonly

Automatic update from web-platform-testsTests for PaymentCurrencyAmount's currencySystem (#9728)

This test is to prove that no one supports this feature - thus can be dropped from the spec.

Related issues:
 * w3c/payment-request#686
 * w3c/payment-request#617

wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728

UltraBlame original commit: 8532450c23ebb162936f6accdba0a878b744925f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
…ySystem, a=testonly

Automatic update from web-platform-testsTests for PaymentCurrencyAmount's currencySystem (#9728)

This test is to prove that no one supports this feature - thus can be dropped from the spec.

Related issues:
 * w3c/payment-request#686
 * w3c/payment-request#617

wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728

UltraBlame original commit: 8532450c23ebb162936f6accdba0a878b744925f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant