Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #129 #153

Closed
wants to merge 8 commits into from
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/
12 changes: 3 additions & 9 deletions specs/paymentrequest.html
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ <h2>ShippingAddress interface</h2>
<pre class="idl">
interface ShippingAddress {
readonly attribute DOMString regionCode;
readonly attribute sequence<DOMString> addressLine;
readonly attribute sequence&lt;DOMString&gt; addressLine;
readonly attribute DOMString administrativeArea;
readonly attribute DOMString locality;
readonly attribute DOMString dependentLocality;
Expand Down Expand Up @@ -842,7 +842,7 @@ <h2>PaymentResponse interface</h2>
readonly attribute DOMString methodName;
readonly attribute object details;

Promise&lt;void&gt; complete(boolean success);
Promise&lt;void&gt; complete();
};
</pre>

Expand All @@ -866,9 +866,7 @@ <h2>PaymentResponse interface</h2>
<section>
<h2>complete()</h2>
<p>The <code><dfn>complete</dfn></code> method must be called after the user has accepted the payment
request and the [[\acceptPromise]] has been resolved. The <code>complete</code> method
takes a boolean argument that indicates the payment was successfully processed if <code>true</code> and
that processing failed if <code>false</code>. Calling the <code>complete</code> method tells the user
request and the [[\acceptPromise]] has been resolved. Calling the <code>complete</code> method tells the user
agent that the user interaction is over (and should cause any remaining user interface to be closed).</p>

<div class="issue" data-number="17" title="complete() should take a string argument not boolean">
Expand All @@ -885,10 +883,6 @@ <h2>complete()</h2>
</li>
<li>Set the value of the internal slot [[\completeCalled]] to <em>true</em>.</li>
<li>Return <em>promise</em> and asynchronously perform the remaining steps.</li>
<li>
Pass the value of <code>success</code> to the <a>Payment App</a> that accepted the
payment request.
</li>
<li>Close down any remaining user interface.</li>
<li>Resolve <em>promise</em> with <code>undefined</code>.</li>
</ol>
Expand Down