Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requesting billing address #749

Merged
merged 16 commits into from
Nov 28, 2018
Merged

Support requesting billing address #749

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5ac10f2
Add ability to request payer's address
marcoscaceres Jul 6, 2018
1e27643
review nits
marcoscaceres Jul 10, 2018
2fd6717
nit
marcoscaceres Jul 10, 2018
0a9d479
Define payerAddress more like shippingAddress
marcoscaceres Jul 10, 2018
693094f
tidy
marcoscaceres Jul 16, 2018
01018e5
refactor based on discussion
marcoscaceres Aug 15, 2018
0083422
Do IDL conversion
marcoscaceres Aug 15, 2018
b2239f2
fixup
marcoscaceres Aug 15, 2018
292ac8f
put requestBillingAddress in alpha order
marcoscaceres Aug 15, 2018
0819123
remove requestBillingAddress
marcoscaceres Aug 17, 2018
3a1ee9f
Review feedback
marcoscaceres Aug 20, 2018
59574dc
DOMString or null
marcoscaceres Aug 20, 2018
b8acadd
Revert position of requestPayerName
marcoscaceres Aug 20, 2018
5bf3b8b
Run update algo with null as needed
marcoscaceres Aug 20, 2018
fbd58b4
s/identifier/pmi
marcoscaceres Aug 20, 2018
e91e6b4
Revert "remove requestBillingAddress"
marcoscaceres Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 55 additions & 14 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,8 +1051,8 @@ <h2>
If <var>detailsPromise</var> was passed, then:
<ol>
<li>Run the <a>update a <code>PaymentRequest</code>'s details
algorithm</a> with <var>detailsPromise</var> and
<var>request</var>.
algorithm</a> with <var>detailsPromise</var>, <var>request</var>,
and null.
</li>
<li>Wait for the <var>detailsPromise</var> to settle.
<p class="note">
Expand Down Expand Up @@ -1972,6 +1972,7 @@ <h2>
<pre class="idl">
dictionary PaymentOptions {
boolean requestPayerName = false;
boolean requestBillingAddress = false;
boolean requestPayerEmail = false;
boolean requestPayerPhone = false;
boolean requestShipping = false;
Expand All @@ -1984,6 +1985,19 @@ <h2>
options desired for the payment request.
</p>
<dl>
<dt>
<dfn>requestBillingAddress</dfn> member
</dt>
<dd data-link-for="PaymentMethodChangeEvent">
A boolean that instructs the <a>user agent</a> to get the billing
address associated with a <a>payment method</a> (e.g., the billing
address associated with a credit card). Typically, the user agent
will return the billing address as part of the
<a>PaymentMethodChangeEvent</a>'s <a>methodDetails</a>, albeit
possibly with parts of the address redacted for privacy reasons. A
merchant can use this information to, for example, calculate tax in
certain jurisdictions.
</dd>
<dt>
<dfn>requestPayerName</dfn> member
</dt>
Expand Down Expand Up @@ -4034,9 +4048,16 @@ <h2>
</li>
<li>Set <var>event</var>.<a>[[\waitForUpdate]]</a> to true.
</li>
<li>Let <var>pmi</var> be null.
</li>
<li>If <var>event</var> has a <a data-link-for=
"PaymentMethodChangeEvent">methodName</a> attribute, set
<var>pmi</var> to the <a data-link-for="PaymentMethodChangeEvent">
methodName</a> attribute's value.
</li>
<li>Run the <a>update a <code>PaymentRequest</code>'s details
algorithm</a> with <var>detailsPromise</var> and
<var>request</var>.
algorithm</a> with <var>detailsPromise</var>, <var>request</var>,
and <var>pmi</var>.
</li>
</ol>
</section>
Expand Down Expand Up @@ -4589,16 +4610,18 @@ <h2>
<p>
The <dfn>update a <code>PaymentRequest</code>'s details
algorithm</dfn> takes a <a>PaymentDetailsUpdate</a>
<var>detailsPromise</var> and a <a>PaymentRequest</a>
<var>request</var>. The steps are conditional on the
<var>detailsPromise</var> settling. If <var>detailsPromise</var>
never settles then the payment request is blocked. The user agent
SHOULD provide the user with a means to abort a payment request.
Implementations MAY choose to implement a timeout for pending updates
if <var>detailsPromise</var> doesn't settle in a reasonable amount of
time. If an implementation chooses to implement a timeout, they MUST
execute the steps listed below in the "upon rejection" path. Such a
timeout is a fatal error for the payment request.
<var>detailsPromise</var>, a <a>PaymentRequest</a>
<var>request</var>, and <var>pmi</var> that is either a DOMString or
null (a <a>payment method identifier</a>). The steps are conditional
on the <var>detailsPromise</var> settling. If
<var>detailsPromise</var> never settles then the payment request is
blocked. The user agent SHOULD provide the user with a means to abort
a payment request. Implementations MAY choose to implement a timeout
for pending updates if <var>detailsPromise</var> doesn't settle in a
reasonable amount of time. If an implementation chooses to implement
a timeout, they MUST execute the steps listed below in the "upon
rejection" path. Such a timeout is a fatal error for the payment
request.
</p>
<ol class="algorithm">
<li>Set <var>request</var>.<a>[[\updating]]</a> to true.
Expand Down Expand Up @@ -4780,6 +4803,24 @@ <h2>
</li>
</ol>
</li>
<li data-link-for="PaymentDetailsUpdate">If the
<a>paymentMethodErrors</a> member is present and
<var>identifier</var> is not null:
<ol>
<li>If required by the specification that defines the
<var>pmi</var>, then <a data-cite=
"!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> <a>
paymentMethodErrors</a> to an IDL value.
</li>
<li>If conversion results in a <a data-cite=
"!WEBIDL#dfn-exception">exception</a> <var>error</var>,
<a>abort the update</a> with <var>error</var>.
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
</li>
<li>The <a>payment handler</a> SHOULD display an error for
each relevant erroneous field of <a>paymentMethodErrors</a>.
</li>
</ol>
</li>
<li>Update the <a>PaymentRequest</a> using the new details:
<ol>
<li data-link-for="PaymentDetailsUpdate">If the <a>total</a>
Expand Down