-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fine-grained errors for payment methods #752
Conversation
On Basic Card side: w3c/payment-method-basic-card#58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits editorially. Unsure on consensus status.
index.html
Outdated
@@ -3213,6 +3213,28 @@ <h2> | |||
<li>Set <var>response</var>.<a>[[\retryPromise]]</a> to | |||
<var>retryPromise</var>. | |||
</li> | |||
<li data-link-for="PaymentValidationErrors">If | |||
<var>errorFields</var>'s <a>paymentMethod</a> member was passed, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"was passed" -> "is present"
index.html
Outdated
<a>payment method</a>, then <a data-cite= | ||
"!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> | ||
<var>errorFields</var> <a>paymentMethod</a> to an IDL value. | ||
Otherwise, <a data-cite= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure whether this buys anything, versus just ignoring it. Maybe it's useful for web-based payment handlers??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what I was thinking... not all payment handlers will be formally specified, so this allows stuff to be passed to "https://bob.pay".
index.html
Outdated
if required by the specification that defines <var>response</var>'s | ||
<a>payment method</a>, then <a data-cite= | ||
"!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> | ||
<var>errorFields</var> <a>paymentMethod</a> to an IDL value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "to an IDL value of the type specified there" or similar?
index.html
Outdated
<dfn>paymentMethod</dfn> member | ||
</dt> | ||
<dd> | ||
A payment method specific error. See, for example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singular -> plural?
b30c368
to
842812c
Compare
Thanks for checking on status. We have an implementer's call wrt this and other features coming up on the 18th. |
Added link to Gecko tracking bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1473081). |
842812c
to
0817937
Compare
YAY!!! WELCOME BACKK!!!! |
THANKS! |
Hey @rsolomakhin see email from Ian just now, too. ;-) |
Just missed the email and the meeting, sorry! I will join the next one. |
@rsolomakhin, when you get to it, could you drop in a tracking bug for Blink? Same for any other bugs. |
@marcoscaceres, done. What's the meaning of the checkbox? |
Not much. It’s satisfying to click tho. |
0817937
to
ae06907
Compare
As this depends on payment method, I'll test this as part of Basic Card: w3c/payment-method-basic-card#58 |
closes #727
The following tasks have been completed:
Implementation commitment:
Impact on Payment Handler spec?
See: w3c/payment-handler#306
So we can do, for example:
Preview | Diff