Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: use different global #997

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Editorial: use different global #997

merged 1 commit into from
Sep 21, 2022

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 21, 2022 •
edited by pr-preview bot
Loading

closes #994

We can use the "this"'s relevant global object instead. Also found us a bonus bug.

Preview | Diff

stephenmcgruer
stephenmcgruer approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@stephenmcgruer stephenmcgruer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and good catch of the longstanding bug too :)

@marcoscaceres
Copy link
Member Author

Thanks for the speedy review, @stephenmcgruer!

@marcoscaceres marcoscaceres merged commit ca8b6a5 into gh-pages Sep 21, 2022
@marcoscaceres marcoscaceres deleted the editorial_fixup branch September 21, 2022 18:42
marcoscaceres added a commit that referenced this pull request Feb 5, 2024
@marcoscaceres
Editorial: use different global (#997)
1a4263b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmcgruer stephenmcgruer stephenmcgruer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"current settings object's relevant global object" is not defined
2 participants
@marcoscaceres @stephenmcgruer