Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary default value #298

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 23, 2019

@saschanaz
Copy link
Member Author

Marked as non substantive for IPR from ash-nazg.

@@ -247,7 +247,7 @@ <h2><code>PointerEvent</code> Interface</h2>
boolean isPrimary = false;
};

[Constructor(DOMString type, optional PointerEventInit eventInitDict), Exposed=Window]
[Constructor(DOMString type, optional PointerEventInit eventInitDict = {}), Exposed=Window]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what this means. Where is the default dictionary values that are specified before this line? Is there a way to set the default value to a dictionary with the values specified above? @saschanaz @Ms2ger

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The = {} part should be same as passing JavaScript {}, which means those default values are automatically set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have to admit that i'm lost about the actual meaning of the whole IDL thing ... but I trust @saschanaz you know more what this is about etc (and it does look in line with what some other specs have done to update their IDL)

@patrickhlauke patrickhlauke self-requested a review August 23, 2019 08:22
@patrickhlauke
Copy link
Member

(going to leave it open for a bit just in case @Ms2ger has some comment/suggestion about this)

Copy link

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct change, yes. Thank you.

@patrickhlauke
Copy link
Member

thanks for confirming @Ms2ger - and sorry for doubting you @saschanaz 👍

@patrickhlauke patrickhlauke merged commit 13ff29f into w3c:gh-pages Aug 23, 2019
@saschanaz saschanaz deleted the patch-2 branch August 23, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants