-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dictionary default value #298
Conversation
Marked as non substantive for IPR from ash-nazg. |
@@ -247,7 +247,7 @@ <h2><code>PointerEvent</code> Interface</h2> | |||
boolean isPrimary = false; | |||
}; | |||
|
|||
[Constructor(DOMString type, optional PointerEventInit eventInitDict), Exposed=Window] | |||
[Constructor(DOMString type, optional PointerEventInit eventInitDict = {}), Exposed=Window] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what this means. Where is the default dictionary values that are specified before this line? Is there a way to set the default value to a dictionary with the values specified above? @saschanaz @Ms2ger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The = {}
part should be same as passing JavaScript {}
, which means those default values are automatically set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have to admit that i'm lost about the actual meaning of the whole IDL thing ... but I trust @saschanaz you know more what this is about etc (and it does look in line with what some other specs have done to update their IDL)
(going to leave it open for a bit just in case @Ms2ger has some comment/suggestion about this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct change, yes. Thank you.
thanks for confirming @Ms2ger - and sorry for doubting you @saschanaz 👍 |
Required after whatwg/webidl#750. (Found from web-platform-tests/wpt#18382)
Preview | Diff