-
Notifications
You must be signed in to change notification settings - Fork 31
Transition Level 1 to CR #76
Comments
@yoavweiss any chance you could help with the web-platform-tests for this one? Also, any pointers for Safari discussions/bugs we can link to? |
@igrigorik - on my TODO list. If I'm realistic, it probably won't happen before Velocity AMS, but I'll carve out the time to get it done not long after. Master WebKit issue is https://bugs.webkit.org/show_bug.cgi?id=158720 |
@yoavweiss sounds great, thanks! |
I know it is already in progress but I want to ensure that we are clear that the tests are super critical for this spec given its "background" nature. I assert that we MUST get tests into Web Platform Tests before moving this to the next phase. |
Later than I thought, but first batch of tests is at web-platform-tests/wpt#4316 |
@toddreifsteck @igrigorik - I'd appreciate your review of the tests and mostly a list of scenarios which are not currently covered. |
web-platform-tests/wpt#4316 (which was great to see land) noted that this was an incomplete set of tests. @yoavweiss do you know if there are additional tests that need to be landed beyond #92? |
@yoavweiss @igrigorik |
@siusin @yoavweiss @igrigorik I believe a TAG review is supposed to be part of every new spec's publishing process. We should get this spec on the list, but I don't believe that needs to block the request to publish. |
With 2.5 shipping implementations and presence in 0.9% of page views, I think it's a bit late for that :/ While we can go through the motions, I don't think we'd be able to act on any recommendations that'd result in breaking changes. |
I'd suggest we at least formally ask the TAG if they wish to review this, also the Web Plat WG. It won't take long... |
Hmm, I'm surprised we missed the formal TAG bit here -- I'll take the blame for that, should have caught it earlier! Pinging TAG for formal review sgtm, with an explicit note that this has already shipped and has a good ramp on adoption. Yoav, would you be willing to drive that? |
[Draft] Call for Review -- TAG Review:I'm requesting a TAG review of:
Further details (optional):
You should also know that...The Preload spec has already got 2.5 shipping implementations and presence in 0.9% of page views. We'd prefer the TAG provide feedback as (please select one):
Self-Review Questionnare on Security and Privacy:
@igrigorik @yoavweiss could you give a quick check of the above review details before we send out the wide review requests? |
@siusin thanks for drafting this! GH formatting was broken in a few places --> updated. LGTM. |
@siusin For what it's worth, it seems two of the test suites fail over HTTP (in Chrome at least). Might want to link w3c-test.org over HTTPS instead. |
Done. Thanks @Krinkle ! |
Opened a TAG review request at w3ctag/design-reviews#202 |
CR Published on 26-Oct. Thanks all for getting this done. |
@siusin Thank you for publishing! :) |
Yay! Thanks all. |
The text was updated successfully, but these errors were encountered: