Introduce PresentationRequest and defaultRequest. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .catch(endSession); | ||
| // presId is mandatory when joining a session. | ||
| if (presId) { | ||
| var request = new PresentationRequest(presUrl); |
There was a problem hiding this comment.
I think in the examples, we are reusing all the definitions from the previous ones, so there's no need to create a new PresentationRequest in each example. It might confuse developers, who will create a separate request availability, starting and joining presentation, etc.
mounirlamouri
force-pushed
the
presentation-request
branch
from
7ae1062
to
cccab34
Compare
|
Please take another look. |
| @@ -332,8 +333,9 @@ | |||
| availability.onchange = function() { handleAvailabilityChange(this.value); }; | |||
| }.catch(function() { | |||
| // Availability monitoring is not supported by the platform, discovery of presentation | |||
| // displays will happen only after startSession() call. Pretend the devices are | |||
| // available for simplicity (one could implement the third state for the button). | |||
| // displays will happen only after PresentationRequest.start() call. Pretend the | |||
|
Thanks for the contribution @mounirlamouri and the comments @avayvod and @mwatson2. I made some inline comments which I can implement in a followup PR. |
markafoltz
added a commit
that referenced
this pull request
Jul 27, 2015
Introduce PresentationRequest and defaultRequest.
markafoltz
added a commit
that referenced
this pull request
Jul 28, 2015
Editorial changes to pull request #146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138, #86 and #26.