Address issues #254, #269, #273 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That used to be the case, but getAvailability now automatically uses the presentation request URL.
Getting the connectionList attribute now returns the same PresentationConnectionList instance, and only resolves the promise when the set of presentation controllers is non empty (as things stood, the use of a Promise was useless). The commit also drops the step that instructed the receiving user agent to start monitoring incomping presentation connections if not already started. This is done in the "starting a presentation" algorithm, no need to repeat it here.
This update should address last Pull Request comments, as well as #281. Note I ended up introducing two new idioms to talk about the Promise and PresentationConnectionList singletons, as I believe it improves the readability of algorithms, and makes the list of objects that user agents need to maintain explicit. However, as usual, finding names for things is hard. I came up with "presentation controllers monitor" and "presentation controllers promise". It may be possible to find better names. For instance, instead of "monitor", we could use "manager", "holder", "wrapper", "container".
|
@tidoust, I reworded the initialization of the presentation controllers monitor and the presentation controllers promise to make it clear that they are created once (on first connection and first getting). I think this looks pretty good so going ahead and merging. |
This was referenced Apr 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minor spec changes to address outstanding issues.
#254: When is the first presentation connection created in the receiving browsing context?
#269: Only allow one PresentationAvailability per PresentationRequest
#273: PresentationConnectionClosedEventInit.message needs to have a default value