Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PR #277 that addresses issues #254, #269, #273 #278

Merged
merged 4 commits into from
Apr 21, 2016

Commits on Apr 15, 2016

  1. The availabilityUrl is no longer a "parameter" of getAvailability (w3…

    …c#269)
    
    That used to be the case, but getAvailability now automatically uses the
    presentation request URL.
    tidoust committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    fd17dbc View commit details
    Browse the repository at this point in the history
  2. Improvements to "getting the connectionList attribute" steps (w3c#254)

    Getting the connectionList attribute now returns the same
    PresentationConnectionList instance, and only resolves the promise when the
    set of presentation controllers is non empty (as things stood, the use of a
    Promise was useless).
    
    The commit also drops the step that instructed the receiving user agent to start
    monitoring incomping presentation connections if not already started. This is
    done in the "starting a presentation" algorithm, no need to repeat it here.
    tidoust committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    e2424bd View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2016

  1. Configuration menu
    Copy the full SHA
    b309840 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2016

  1. Getting connectionList now always returns the same object

    This update should address last Pull Request comments, as well as w3c#281.
    
    Note I ended up introducing two new idioms to talk about the Promise and
    PresentationConnectionList singletons, as I believe it improves the readability
    of algorithms, and makes the list of objects that user agents need to maintain
    explicit.
    
    However, as usual, finding names for things is hard. I came up with
    "presentation controllers monitor" and "presentation controllers promise".
    It may be possible to find better names. For instance, instead of "monitor", we
    could use "manager", "holder", "wrapper", "container".
    tidoust committed Apr 20, 2016
    Configuration menu
    Copy the full SHA
    34c8b84 View commit details
    Browse the repository at this point in the history