Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline definition of sectioning root elements #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Oct 5, 2023

This does the base minimum to address w3c/pm-wg#3 -- I've inlined the list of elements as mentioned in w3c/pm-wg#3 (comment)

The mix of elements is still odd (body can't occur inside of the body, etc.), and the spec still talks about outlines in relation to these elements, but I'll open a separate issue for those problems.


Preview | Diff

@iherman iherman added the Change-Class-2 Requested changes are of class 2 (per process) label Oct 5, 2023
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a class 2 change, right? I have labeled it as such... (nothing really changes, just the reference change in some way)

@mattgarrish
Copy link
Member Author

Should we go ahead and merge this, since it's not changing any existing requirements, or do you think we should wait and get a group resolution on the next call?

@iherman
Copy link
Member

iherman commented Nov 9, 2023

The issue is of class 3. I would think that a more explicit approval of the WG is necessary. @wareid @TzviyaSiegman @shiestyle, maybe we could make an email review call to approve changes of this sort. This seems to have worked before.

On the editorial side: @mattgarrish, I am not sure how you intend to manage this in general, but shouldn't the document be prepared for the candidate correction phase? That is what class 3 requires...

@iherman
Copy link
Member

iherman commented Nov 9, 2023

I just see that the PR is marked as class 2, whereas #3 is set as class 3. Which one is correct? This should be in sync...

@mattgarrish
Copy link
Member Author

We're not fully addressing what is in the pm-wg tracker issue, so I don't know what needs to be done there. It maybe stays open as class three but refers now to #264.

This is the change we discussed in that thread that avoids us making a class 3 change until we have more input on how to change the toc processing algorithm (i.e., it just inlines the now-missing element list from html). Fixing #264 will fix the pm-wg issue.

@iherman
Copy link
Member

iherman commented Nov 9, 2023

@mattgarrish yes, I remember now. #263 (comment) is moot... but then we should not make w3c/pm-wg#3 automatically closed if this PR is merged.

Answering to your original question with a fresh eye: in my view yes, it could be merged. But our fearless chairs should also give their opinion :-)

@mattgarrish
Copy link
Member Author

we should not make w3c/pm-wg#3 automatically closed if this PR is merged.

Right, I've stripped the reference, although I'm not sure it would have worked as I don't think I have access to close issues across to that repository.

@iherman
Copy link
Member

iherman commented Nov 9, 2023

we should not make w3c/pm-wg#3 automatically closed if this PR is merged.

Right, I've stripped the reference, although I'm not sure it would have worked as I don't think I have access to close issues across to that repository.

Don't know either, but I have just given you "maintain" rights on that repo as well, just in case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change-Class-2 Requested changes are of class 2 (per process)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants