Tests for aggregates when the pattern match is empty (#61)

* Tests for aggregates when the pattern match is empty * Update sparql11/data-sparql11/aggregates/manifest.ttl Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net> * Update sparql11/data-sparql11/aggregates/manifest.ttl Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net> * Update sparql11/data-sparql11/aggregates/manifest.ttl Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net> * Update sparql11/data-sparql11/aggregates/manifest.ttl Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net> * Rename agg-empty-group as agg-empty-group-max; swap agg-empty-group-count 1 and 2 Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
w3c · May 9, 2020 · 4dd2ac9 · 4dd2ac9
1 parent dc237e3
commit 4dd2ac9
Show file tree

Hide file tree

Showing 9 changed files with 89 additions and 11 deletions.
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-count-1.rq b/sparql11/data-sparql11/aggregates/agg-empty-group-count-1.rq
@@ -0,0 +1,7 @@
+PREFIX : <http://example/>
+
+SELECT (count(*) AS ?C)
+WHERE {
+   ?s :p ?x
+}
+GROUP BY ?s
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-count-1.srj b/sparql11/data-sparql11/aggregates/agg-empty-group-count-1.srj
@@ -0,0 +1,10 @@
+{
+  "head": {
+    "vars": [ "C" ]
+  } ,
+  "results": {
+    "bindings": [
+
+    ]
+  }
+}
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-count-2.rq b/sparql11/data-sparql11/aggregates/agg-empty-group-count-2.rq
@@ -0,0 +1,6 @@
+PREFIX : <http://example/>
+
+SELECT (count(*) AS ?C)
+WHERE {
+   ?s :p ?x
+}
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-count-2.srj b/sparql11/data-sparql11/aggregates/agg-empty-group-count-2.srj
@@ -0,0 +1,12 @@
+{
+  "head": {
+    "vars": [ "C" ]
+  } ,
+  "results": {
+    "bindings": [
+      {
+        "C": { "type": "literal" , "datatype": "http://www.w3.org/2001/XMLSchema#integer" , "value": "0" }
+      }
+    ]
+  }
+}
diff --git a/...ta-sparql11/aggregates/agg-empty-group.rq → ...rql11/aggregates/agg-empty-group-max-1.rq b/...ta-sparql11/aggregates/agg-empty-group.rq → ...rql11/aggregates/agg-empty-group-max-1.rq
diff --git a/...-sparql11/aggregates/agg-empty-group2.srx → ...ql11/aggregates/agg-empty-group-max-1.srx b/...-sparql11/aggregates/agg-empty-group2.srx → ...ql11/aggregates/agg-empty-group-max-1.srx
@@ -5,7 +5,5 @@
 		<variable name="max"/>
 	</head>
 	<results>
-		<result>
-		</result>
 	</results>
 </sparql>
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-max-2.rq b/sparql11/data-sparql11/aggregates/agg-empty-group-max-2.rq
@@ -0,0 +1,5 @@
+PREFIX ex: <http://example.com/>
+SELECT (MAX(?value) AS ?max)
+WHERE {
+	?x ex:p ?value
+}
diff --git a/sparql11/data-sparql11/aggregates/agg-empty-group-max-2.srx b/sparql11/data-sparql11/aggregates/agg-empty-group-max-2.srx
@@ -0,0 +1,10 @@
+<?xml version="1.0"?>
+<sparql xmlns="http://www.w3.org/2005/sparql-results#">
+	<head>
+		<variable name="max"/>
+	</head>
+	<results>
+		<result>
+		</result>
+	</results>
+</sparql>
diff --git a/sparql11/data-sparql11/aggregates/manifest.ttl b/sparql11/data-sparql11/aggregates/manifest.ttl
@@ -37,7 +37,10 @@
     :agg-sample-01 
     :agg-err-01
     :agg-err-02
-    :agg-empty-group2
+    :agg-empty-group-max-1
+    :agg-empty-group-max-2
+    :agg-empty-group-count-1
+    :agg-empty-group-count-2
 ) .
 
 
@@ -333,15 +336,42 @@
     mf:result  <agg-err-02.srx>
     .    
 
-:agg-empty-group2 rdf:type mf:QueryEvaluationTest ;
-	mf:name "agg empty group" ;
-    mf:name "Aggregate over empty group resulting in a row with unbound variables" ;
+## Aggregate on empty pattern match.
+
+:agg-empty-group-max-1 rdf:type mf:QueryEvaluationTest ;
+	mf:name "agg on empty set, explicit grouping" ;
+    rdfs:comment "aggregating empty results returns no rows, as there are no grouped results." ;
+	mf:feature sparql:aggregate ;
+    mf:action
+         [ qt:query  <agg-empty-group-max-1.rq> ;
+           qt:data   <empty.ttl> ] ;
+    mf:result  <agg-empty-group-max-1.srx>
+    .    
+
+:agg-empty-group-max-2 rdf:type mf:QueryEvaluationTest ;
+	mf:name "agg on empty set, no grouping" ;
+    rdfs:comment "aggregating empty results with no group-by always returns a single result." ;
 	mf:feature sparql:aggregate ;
-	rdfs:seeAlso <http://answers.semanticweb.com/questions/17410/semantics-of-sparql-aggregates> ;
-    dawgt:approval dawgt:Approved ;
-    dawgt:approvedBy <http://www.w3.org/2009/sparql/meeting/2012-10-30#resolution_2> ;
     mf:action
-         [ qt:query  <agg-empty-group.rq> ;
+         [ qt:query  <agg-empty-group-max-2.rq> ;
            qt:data   <empty.ttl> ] ;
-    mf:result  <agg-empty-group2.srx>
+    mf:result  <agg-empty-group-max-2.srx>
     .    
+
+:agg-empty-group-count-1  rdf:type mf:QueryEvaluationTest ;
+    mf:name "COUNT: no match, with group";
+    rdfs:comment "counting no results with grouping returns no results." ;
+    mf:action
+         [ qt:query  <agg-empty-group-count-1.rq> ;
+           qt:data   <empty.ttl> ] ;
+    mf:result  <agg-empty-group-count-1.srj>
+    .
+
+:agg-empty-group-count-2  rdf:type mf:QueryEvaluationTest ;
+	mf:name "COUNT: no match, no group" ;
+    rdfs:comment "counting no results without grouping always returns a single result." ;
+    mf:action
+         [ qt:query  <agg-empty-group-count-2.rq> ;
+           qt:data   <empty.ttl> ] ;
+    mf:result  <agg-empty-group-count-2.srj>
+    .