[tests] Adapt to mock headers structure #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mock library had a bug on the structure of headers returned. Our test code was taking this bug into account. Bug got fixed in Node.js v18.17.0. Test code now support both possibilities.
tidoust
added a commit
that referenced
this pull request
Aug 1, 2023
Breaking change: - Make Reffy skip discontinued specs by default ([#1341](#1341)) Specs in browser-specs will be more consistently preserved in the list, even when they get abandoned or replaced by other proposals, so that browser-specs can act as a useful source for Specref. Reffy will no longer crawl specs that have a "discontinued" standing in browser-specs. At the time of the change, this affects 5 specs, which used to be crawled by default, and no longer are: DOM-Level-2-Style, selectors-non-element-1, tracking-dnt, wpub-ann, wpub. Feature patches: - Bump action versions in job (#1342) - [tests] Adapt to mock headers structure (#1343) Dependency bumps: - Bump rollup from 3.26.2 to 3.27.0 (#1345) - Bump semver from 7.5.3 to 7.5.4 (#1330) - Bump respec from 34.1.4 to 34.1.6 (#1339) - Bump webidl2 from 24.4.0 to 24.4.1 (#1332) - Bump puppeteer from 20.8.0 to 20.9.0 (#1338) - Bump web-specs from 2.63.0 to 2.65.0 (#1346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mock library had a bug on the structure of headers returned. Our test code was taking this bug into account. Bug got fixed in Node.js v18.17.0. Test code now support both possibilities.