Events extraction: support "given" for functional events #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Notifications API now uses "given" to fire a functional event: https://notifications.spec.whatwg.org/#fire-a-service-worker-notification-event That terminology is aligned with Infra, so we should support it as well. The code was extracting an event type `"given"`. This update makes it skip "given", as it also skips "named". The end result for the above example is that the code no longer extracts anything. That is what we want: this is a generic algorithm, the event type `"name"` is correctly being rejected as being a variable name, and not an actual event type name. (Detected because "given" triggered a data curation error in Webref)
dontcallmedom
approved these changes
Aug 26, 2024
tidoust
added a commit
that referenced
this pull request
Aug 26, 2024
Bug fixed: - Events extraction: support "given" for functional events (#1654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Notifications API now uses "given" to fire a functional event: https://notifications.spec.whatwg.org/#fire-a-service-worker-notification-event
That terminology is aligned with Infra, so we should support it as well.
The code was extracting an event type
"given". This update makes it skip "given", as it also skips "named".The end result for the above example is that the code no longer extracts anything. That is what we want: this is a generic algorithm, the event type
"name"is correctly being rejected as being a variable name, and not an actual event type name.(Detected because "given" triggered a data curation error in Webref)
PS: Also fixed tabs and spaces mixup!!!