Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code needed to annotate idl definitions in HTML spec #631

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Remove code needed to annotate idl definitions in HTML spec #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af76f2
Remove code needed to annotate idl definitions in HTML spec
dontcallmedom Jun 8, 2021
70da052
Remove tests related to no-longer relevant HTML spec exception
dontcallmedom Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/browserlib/extract-dfns.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,15 +383,6 @@ function preProcessHTML() {
}
let m;

if (el.closest("code.idl")) {
// we look if that matches a top-level idl name
let idlTerm = idlTree.find(item => item.name === el.textContent);
if (idlTerm) {
// we split at space to cater for "interface mixin"
el.dataset.dfnType = idlTerm.type.split(' ')[0];
return;
}
}
if ((m = el.id.match(/^attr-([^-]+)-([^-]+)$/))) {
// e.g. attr-ul-type
el.dataset.dfnType = 'element-attr';
Expand Down
9 changes: 0 additions & 9 deletions tests/extract-dfns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,6 @@ const tests = [
definedIn: "heading"}],
spec: "html"
},
{title: "handles HTML spec convention for defining element interfaces",
html: '<pre><code class="idl">interface <dfn id="htmlhrelement"><c- g="">HTMLHRElement</c-></dfn> {};</code></pre>',
changesToBaseDfn: [{id: "htmlhrelement",
access: "public",
type: "interface",
linkingText: ["HTMLHRElement"],
definedIn: "pre"}],
spec: "html"
},
{title: "handles finding IDL type across mixins and partial",
html: '<dfn id="dom-navigator-taintenabled"><code>taintEnabled()</code></dfn>',
changesToBaseDfn: [{id: "dom-navigator-taintenabled",
Expand Down