Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

as=html => as=document (closes #79) #80

Merged
merged 1 commit into from
Apr 30, 2018
Merged

as=html => as=document (closes #79) #80

merged 1 commit into from
Apr 30, 2018

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Apr 30, 2018 •
edited by pr-preview bot
Loading

@yoavweiss
Copy link
Contributor

Thanks for catching that! :) I wonder if we should replace those values or remove as altogether. (although #78 raises a use-case for it)

yoavweiss
yoavweiss approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss
Copy link
Contributor

Probably easiest to merge this change and see in the future regarding as removal.

@yoavweiss yoavweiss merged commit 489fef6 into gh-pages Apr 30, 2018
@yoavweiss yoavweiss deleted the marcoscaceres-patch-1 branch April 30, 2018 08:57
@igrigorik
Copy link
Member

Probably easiest to merge this change and see in the future regarding as removal.

+1. I thought we did already.. Is there a use case for as on prefetch? If not, let's remove it to reduce confusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoscaceres @yoavweiss @igrigorik