editorial: Use new HTML activation model #252
Conversation
|
cc @mustaqahmed |
rakuco
force-pushed
the
new-html-activation-model
branch
from
a59a100 to
e32903b
Compare
There was a problem hiding this comment.
This looks good but I would be careful about current global object.
cc-ing @domenic in case he has a better suggestion.
| @@ -291,8 +291,8 @@ <h2> | |||
| <li>If |state| is {{PermissionState["prompt"]}}, run the following | |||
| steps: | |||
| <ol> | |||
| <li>If these <a>obtain permission</a> steps were not <a>triggered | |||
| by user activation</a>, return {{PermissionState["denied"]}}. | |||
| <li>If the <a>current global object</a> does not have [=transient | |||
There was a problem hiding this comment.
We have to be a bit careful about "current global object" here because transient user activation is defined only for Window. I think we can instead say:
If current global object is a Window and it does not have transient activation...
There was a problem hiding this comment.
Thanks for the quick review. I've added a separate step above to handle the non-Window case and bail out earlier.
index.html
Outdated
| from the <a>browsing context</a> who created it, e.g. the <a>browsing | ||
| context</a> that is exists in the {{DedicatedWorkerGlobalScope}}'s | ||
| [=WorkerGlobalScope/owner set=]. | ||
| which means that it will never have [=transient activation=]. |
There was a problem hiding this comment.
Please consider the last point above for this para too. Something like:
If the current global object is a DedicatedWorkerGlobalScope, it won't have transient activation...
There was a problem hiding this comment.
I've reworded things a bit, please take another look.
Adapt to whatwg/html#5129 and follow the spec editing advice from https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User Activation: Guidance for spec authors") by replacing "triggered by user activation" with "the current global object has transient activation". This makes ReSpec happy again.
rakuco
force-pushed
the
new-html-activation-model
branch
from
e32903b to
097b84d
Compare
|
Thanks for isolating the undefined case. LGTM too. |
Adapt to whatwg/html#5129 and follow the spec editing advice from
https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User
Activation: Guidance for spec authors") by replacing "triggered by user
activation" with "the current global object has transient activation".
This makes ReSpec happy again.
Preview | Diff