Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant check #368

Closed
wants to merge 1 commit into from
Closed

Remove redundant check #368

wants to merge 1 commit into from

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Dec 18, 2023

Closes #???

This check is not needed (or it's too eager because it's done on the wrong thread)... we do the check visibility check synchronously first.

There are rules already in place as to what to do if the visibility is lost after the lock is acquired.

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

@marcoscaceres marcoscaceres requested a review from rakuco December 18, 2023 02:41
@vinhill
Copy link

vinhill commented Dec 19, 2023

I have some concerns about this check being necessary to prevent a race condition. While the task created in step 7.3 is still queued, the document could loose visibility, release all locks in document.[[ActiveLocks]]["screen"] and only afterwards, the task will run, acquire a new lock and place it in document.[[ActiveLocks]].

@marcoscaceres
Copy link
Member Author

Yeah, that's true... theoretically that could happen. Let's leave this in place then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants