Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve display on mobile phones #15

Merged
merged 4 commits into from
May 18, 2023
Merged

improve display on mobile phones #15

merged 4 commits into from
May 18, 2023

Conversation

domel
Copy link
Contributor

@domel domel commented May 7, 2023

@domel domel added the spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) label May 7, 2023
@domel domel requested review from afs and rubensworks May 7, 2023 21:50
@rubensworks
Copy link
Member

Not sure the break-all is the right way forward here.

This is the result on my screen (non-mobile):

Before:
Screenshot 2023-05-08 at 08 33 06

After:
Screenshot 2023-05-08 at 08 33 18

The "before" version looks better IMO.

@domel
Copy link
Contributor Author

domel commented May 8, 2023

Yes, but at the same time "after" looks better in mobile phones. See w3c/rdf-concepts#40 (comment)

@gkellogg
Copy link
Member

gkellogg commented May 8, 2023

Maybe it wants a media selector so the change only kicks in for displays less than a certain size.

@domel
Copy link
Contributor Author

domel commented May 8, 2023

Yes, as a wrote in different PR I can provide @media

@domel
Copy link
Contributor Author

domel commented May 8, 2023

I've added media queries. I hope that it addresses your concerns.

@afs
Copy link
Contributor

afs commented May 8, 2023

Discussion on rdf-concepts?

@domel
Copy link
Contributor Author

domel commented May 18, 2023

@rubensworks or @afs Can you take a look at it?

@afs
Copy link
Contributor

afs commented May 18, 2023

Will try to.

But where is discussion on the changes happening because the PR changes that impact all SPARQL documents?

I use github for the dayjob and for open source. The number of notifications from RDF-star about mobile appearance has pushed out everything else.

@domel
Copy link
Contributor Author

domel commented May 18, 2023

@afs Thanks! Yes, all PRs are on the same topic, they are similar changes (of course they are a bit different because they have a different structure). At the moment, most PRs are accepted. As for the SPARQL subgroup specs, the PRs apply only to sparql-protocol and sparql-query. The rest of the specs have no problems with RWD so I don't want to change them.

@afs
Copy link
Contributor

afs commented May 18, 2023

What about the pre changes 4em to 1em?

@domel
Copy link
Contributor Author

domel commented May 18, 2023

4em was a big value ofmargin-right, which wastes a lot of space in small devices. I've changed it to 1em and now the examples are more readable.

@afs
Copy link
Contributor

afs commented May 18, 2023

They apply to other SPARQL specs.

@domel domel merged commit e0a3bd6 into main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants