Alternate take for script enforcement. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2019
annevk
reviewed
Nov 15, 2019
…#3052 As proposed by @annevk, add slots for script URL / text, populate them when calling sink functions, and verify them when a script is prepared, optionally running a default policy on a value read from the DOM if it's different than the slot value. It avoids integration points with DOM mutation algorithms, but we still need to support script.setAttribute('src').
koto
force-pushed
the
integrationstake2
branch
from
cd0322d
to
ebf809d
Compare
|
Merging - this is for scripts only, and does not resolve other elements or setting content attributes yet. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 25, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 27, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 27, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 28, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 29, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 2, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 9, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 9, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924523 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#723017}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 9, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 9, 2019
This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2019
…andling for Trusted Types., a=testonly Automatic update from web-platform-tests [Trusted Types] Implement new <script> handling for Trusted Types. This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 -- wpt-commits: d1e31101085c0ce2563ec39c0315ef84d8d2562a wpt-pr: 20430
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 12, 2019
…andling for Trusted Types., a=testonly Automatic update from web-platform-tests [Trusted Types] Implement new <script> handling for Trusted Types. This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 -- wpt-commits: d1e31101085c0ce2563ec39c0315ef84d8d2562a wpt-pr: 20430 UltraBlame original commit: 55acee2cb32bef02a8b5b10bc95b364f85e82911
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 12, 2019
…andling for Trusted Types., a=testonly Automatic update from web-platform-tests [Trusted Types] Implement new <script> handling for Trusted Types. This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 -- wpt-commits: d1e31101085c0ce2563ec39c0315ef84d8d2562a wpt-pr: 20430 UltraBlame original commit: 55acee2cb32bef02a8b5b10bc95b364f85e82911
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 12, 2019
…andling for Trusted Types., a=testonly Automatic update from web-platform-tests [Trusted Types] Implement new <script> handling for Trusted Types. This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 -- wpt-commits: d1e31101085c0ce2563ec39c0315ef84d8d2562a wpt-pr: 20430 UltraBlame original commit: 55acee2cb32bef02a8b5b10bc95b364f85e82911
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 16, 2019
…andling for Trusted Types., a=testonly Automatic update from web-platform-tests [Trusted Types] Implement new <script> handling for Trusted Types. This follows the proposal at w3c/trusted-types#236 and effectively reverts crrev.com/c/1547746. This replaces the (arguably rather invasive) changes in node.cc and element.cc with more elaborate logic in html_script_element.cc. (I.e., it pushes complexity from the super-classes into a specific subclass, at the expense of making the sub-class do more work.) Bug: 1026549 Change-Id: I929e9e669db7f9e6b8de5a3d0d0df661f109b644 -- wpt-commits: d1e31101085c0ce2563ec39c0315ef84d8d2562a wpt-pr: 20430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: whatwg/dom#789 and whatwg/html#3052
As proposed by @annevk, add slots for script URL / text, populate them
when calling sink functions, and verify them when a script is prepared,
optionally running a default policy on a value read from the DOM if
it's different than the slot value.
It avoids integration points with DOM mutation algorithms, but we still
need to support
script.setAttribute('src'), which is missing here.