Add mark_use_counter recommended use name. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance working group October 2023. Move mark_fully_loaded example inline so that multiple examples are less confusing.
yoavweiss
reviewed
Nov 10, 2023
ksylor
reviewed
Nov 14, 2023
| <dt>"<dfn class="export">mark_fully_visible</dfn>"</dt> | ||
| <dd>The time when the page is considered fully visible to an end-user | ||
| as marked by the developer in their application.</dd> | ||
| <dt>"<dfn class="export">mark_interactive</dfn>"</dt> | ||
| <dd>The time when the page is considered interactive to an end-user as | ||
| marked by the developer in their application.</dd> | ||
| <dt>"<dfn class="export">mark_use_counter</dfn>"</dt> |
There was a problem hiding this comment.
The terminology of use counter is confusing and implies that the browser will be incrementing a counter somewhere, when I don't believe that is the case for this proposal? A term that is meaningful outside of internal chromium terminology might be better - perhaps something like mark_feature_usage?
There was a problem hiding this comment.
That's great feedback, thanks!!
There was a problem hiding this comment.
Sorry I missed this, will update in a follow-up
There was a problem hiding this comment.
Follow-up: #108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #105.
Also move
mark_fully_loadedexample inline so that it's easier to relate examples to recommended mark names now that there are multiple examples.Preview | Diff