For publication/deploy on Thursday 8 December 2022 #174
Conversation
Treegrid and Tree View icons are swapped
Adds support for forked PRs
Fix APG PR link of generated PR body to be consistent
Support content rearchitecture
Address ARIA Practices PR 2417 Feedback
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for wai-aria-practices2 failed.
|
|
@alflennik Do you know why this deployment is failed? The detailed deploy logs are not loading. does this imply that the change cannot be published this week unless @shawna-slh 's team do something about it or do we just need her approval? |
|
@a11ydoer thank you for bringing up the failed checks. They are nothing to worry about. They are caused by an old Netlify account which no longer works, and we are currently in the process of updating the Netlify account associated with the project. See the issue here for more information. |
|
Great! |
|
Very hard to tell on mobile but there seem to be merge conflicts to be resolved. Netlify wont build if conflicts. I see commits I made to fix the dependency problem so that should be OK. |
|
@alflennik I don't understand the merge conflict. Looks like git recognized removal of everything from /content except for that one file. content/about.md does not exist in the main branch. When merging publication into main, the file is in both content and aria/apg/about, so perhaps deleting, commiting, and pushing ... I wasn't sure; will leave it to you or someone else on the eng team to resolve. |
|
I'll checkin with Shawn, sounds like this is for today. The thing I discovered recently is PRs use a full 3 way differentce, not 2 way. So it does not just compare current state but changes on both branches from a common ancestor. So if the file changed on both branches there may a conflict that requires human intervention. The trouble is it doesn't present the issue in any understandable way. |
|
@alflennik given there are issues (above), I would like to do this deployment when you are available. Denis and I are ready early. Please ping me in IRC when you are. I joined #aria-apg |
|
@shawna-slh Good morning, I fixed the conflict. I will message you on IRC as well. |
|
@shawna-slh how long does it take for the changes to be live once they are merged into the publication branch? I want to do some testing of redirects as soon as possible after the deploy. |
|
@mcking65 The deploy failed and @SteveALee is not available to troubleshoot it. Unless Steve becomes available, we will have to revert and postpone the update. Sorry. |
|
Oh, bummer, thx for that update. |
|
@michael-n-cooper says he'll follow up with you to get info to determine when we might have resources to help troubleshoot the issue with this PR not deploying. [edited] |
|
Data point: The WAI website deploy worked before this merge. And when this merge was reverted, and a different PR merged, the deploy worked. So it is indeed a problem with this PR. |
|
Sorry but a bicycle crash has put me out of action for a bit. Nothing too bad. It's not obvious what problem is so will investigate next week |
|
First of all, my condolences @SteveALee, take as much time as you need to get better. Glad to hear it's nothing too bad. About the deploy, I'm not sure if I'll be able to help since I don't know what the issue is. However, there is one issue I just fixed which might be related - I noticed the Gem lock file was missing some metadata that would allow the Gems to work on different architectures. Do we know @shawna-slh if Steve will be able to help get this deploy over the finish line? |
Hi @shawna-slh and @SteveALee, this PR includes the content we would like to deploy tomorrow on December 8, 2022.
The deploy will include support for aria-practices' new content reorganization which was merged today. The main changes to wai-aria-practices are below:
It should be released simultaneously with redirects from the previous URLs to new URLs, which will be handled by @deniak (see #172 for more information).
Preview of how the site should appear is here: aria-practices.netlify.app/aria/apg/
Please let us know if you have any additional concerns. cc @mcking65 @a11ydoer @s3ththompson
Requested publication here