Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For publication / deploy on Tuesday August 1, 2023 #244

Merged
merged 10 commits into from
Aug 1, 2023
Merged

Conversation

howard-e
Copy link
Contributor

Hi @shawna-slh. We would like to deploy a new version of the APG website. This was approved during last week's APG meeting and requested in a recent email thread with @mcking65.

The update includes the following, as sourced from Status of Site Updates > Changes currently queued for next publication:

Skipto menu on all pages: Update skipto.js script to version 5.1.6 (pull #2680)

By jongund on Jun 25, 2023

  • Updates the script that provides skip link functionality at the top of every page in APG.

[View commit b2718f4](w3c/aria-practices@b2718f4


Checkbox Example (Mixed-State): Toggle on keyup to prevent continuous toggling (pull #2722)

By sivakusayan on Jun 25, 2023

Modified JavaScript for Checkbox Example (Mixed-State) so that the state of the checkbox does not change until key up. This change prevents continuous toggling if the user holds down the space key.

This is the same change that was made for Checkbox Example (Two State) in pull request #2518.

This commit fully resolves issue #2425.

View commit 049893e


Example Pages: Change Javascript to JavaScript in h2 elements (pull #2724)

By mcking65 on Jun 19, 2023

Simply fixes a case error where "JavaScript" was written as "Javascript" in an H2 heading on example pages.

View commit 3952625


Feed Example: Convert images to inline SVG (pull #2729)

By frozenzia on Jul 24, 2023

Changes the images used for star ratings of restaurants in the feed example to inline SVG.
Because the build process that converts to Jekyll for the production site separates images into a separate path, the links to the dynamically loaded image assets were being broken by the build process. With this change, the JavaScript is no longer dependent on paths to image files.

View commit 1d85d95


Combobox Pattern: Simplify wording of description in "About This Pattern" section (pull #2733)

By mcking65 on Jul 10, 2023

On the combobox pattern page, in the "About This Pattern" section, revises the first two paragraphs of the description of a combobox.

View commit e716cc2


Add AT Support tables for modal dialog, 1 slider, and navigation menu button (pull #2736)

By mcking65 on Jul 24, 2023

Modifies 3 example pages:

  • Add modal dialog support table
  • Add color viewer slider support table
  • Add support table for navigation menu button

View commit 548d8f6


Reposition AT support tables higher on the page (pull #2737)

By mcking65 on Jul 24, 2023

Moves AT support tables from after the source code sections to before the source code sections.

View commit b3777ac


Landmark Example Pages: remove background colours that cause color contrast failures (pull #2738)

By jnurthen on Jul 24, 2023

Resolves #2384

View commit 7723165


Switch Example Using HTML Checkbox: Fix editorial error in accessibility features documentation (pull #2750)

By Camwyn on Jul 24, 2023

Inaccurate text:
When an element loses focus, its border changes from two pixels to two and padding is increased by two pixels.

Corrected text:
When an element loses focus, its border changes from two pixels to zero and padding is increased by two pixels.

View commit d6cf9d8

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit 6c0eb0e
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/64c7b3ad6b34ee000821ea35
😎 Deploy Preview https://deploy-preview-244--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shawna-slh
Copy link
Contributor

Thank you very much for the clear information. I will publish/deploy Tuesday and will indicate here when it is ready for QA check.

@shawna-slh shawna-slh merged commit 9bd6d9d into publication Aug 1, 2023
@shawna-slh
Copy link
Contributor

Deployed. Ready for QA. @howard-e @mcking65 @a11ydoer

@howard-e
Copy link
Contributor Author

howard-e commented Aug 1, 2023

Deployed. Ready for QA

Thanks!

@a11ydoer
Copy link

a11ydoer commented Aug 1, 2023

@mcking65 I confirmed the successful updates of below PRs in the production site. - PR 2378, PR2737, PR 2736, PR 2733. In particular, Combobox Pattern PR greatly enhanced the readability and understandability.

@mcking65
Copy link
Contributor

mcking65 commented Aug 1, 2023

Thank you @howard-e, @shawna-slh, and @a11ydoer.

I have also verified all the non-visual changes to content and functional fixes to examples. All looks good in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants