-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for data-skipto
parameters
#292
Conversation
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
formatForJekyll.js
to account for data-skipto
parametersdata-skipto
parameters
data-skipto
parametersdata-skipto
parameters
…licable data attribs; update transformHomepage.js to remove conflicting style tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean solution, I like this a lot. I verified that skip-to works on all the different page types, that it's now only loaded once (awesome!), and that the styling and functionality of the different pages aren't impacted.
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: pdating skipto<jugglinmike> s/ pdating/ Updating/ <jugglinmike> github: https://github.com//pull/292 <jugglinmike> Matt_King: It sounds like there's some work that has to be done for which we do not currently have a pull request <jugglinmike> Matt_King: Specifically a change in the aria-practices repository <jugglinmike> howard-e: I suggested to do that in the same pull request which introduces the version updates <jugglinmike> Matt_King: So you're suggesting that we add a commit to gh-2807? <jugglinmike> howard-e: That's right--to add the "data-skipto" attributes <jugglinmike> Matt_King: Can you make that modification? <jugglinmike> howard-e: Sure <jugglinmike> howard-e: It already has a couple approvals; would you like me to re-request approval from you and Jem? <jugglinmike> Matt_King: Yes <jugglinmike> Matt_King: What's the order of merging, here? Can you merge 292 first, allowing us to preview 2807? <jugglinmike> howard-e: I think 292 can be merged. If we merge the main branch into 2807, we can subsequently preview that <jugglinmike> Matt_King: Cool. This will simplify things going forward <Jem> data-skipto="colorTheme:aria; displayOption:popup; containerElement:div" |
See #259. More specifically #259 (comment) which motivated these changes.
This will require w3c/aria-practices#2807 to be merged first. Also
content/patterns/patterns.html
andcontent/patterns/practices.html
will have to be updated with the new skipto script as well in aria-practices.Testing Instructions
Note: I created a testing branch on aria-practices, update-skipto-merged which merges 2807 and aria-practices' main, so there aren't any assumptions that have been missed following w3c/aria-practices#2702 being completed and merged which also plays a part in this work.
.gitmodules
aria-practices repo branch toupdate-skipto-merged
, like the following:git submodule --remote --recursive
to use the latest sample branch's commit instead.Install Jekyll
onwards to run project as expected.skipto
script and new parameters are being used.