Infrastructure: Remove unexpected shared/js/app.js change not yet in w3c/aria-practices and file read check for experimental content
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
howard-e
commented
Jun 25, 2024
| // Generate the usage warning link using app.js link as a starting point | ||
| const scriptSource = document | ||
| .querySelector('[src$="app.js"]') | ||
| .getAttribute('src'); | ||
|
|
||
| const fetchSource = scriptSource.replace('/js/app.js', usageWarningLink); | ||
| const fetchSource = scriptSource.replace( |
There was a problem hiding this comment.
This change is automatic -- coming from running node ./scripts/pre-build
stalgiag
approved these changes
Jun 25, 2024
howard-e
changed the title
shared/js/app.js change not yet in w3c/aria-practicesshared/js/app.js change not yet in w3c/aria-practices and file read check for experimental content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this repository to be in sync with files that should only be coming over from w3c/aria-practices. So this removes code automatically synced from
shared/js/app.jsafter re-runningnode ./scripts/pre-build.Additionally, adds file read safety which is important since w3c/aria-practices#2977 has not yet been merged. It has
content/shared/templates/experimental-example-usage-warning.htmlwhichtransformExample.jslooks for with a defined promise.