Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2033 contrast minimum understanding #3284

Merged
merged 24 commits into from
Aug 29, 2023

Conversation

bruce-usab
Copy link
Contributor

@bruce-usab bruce-usab commented Jul 15, 2023

@bruce-usab bruce-usab self-assigned this Jul 15, 2023
@bruce-usab bruce-usab marked this pull request as draft July 15, 2023 00:00
@bruce-usab bruce-usab marked this pull request as ready for review July 21, 2023 14:50
@bruce-usab bruce-usab requested a review from dbjorge July 21, 2023 14:51
@bruce-usab bruce-usab linked an issue Jul 21, 2023 that may be closed by this pull request
@bruce-usab
Copy link
Contributor Author

bruce-usab commented Jul 21, 2023

Current:

The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by people with moderately low vision (who do not use contrast-enhancing assistive technology). For people without color deficiencies, hue and saturation have minimal or no effect on legibility as assessed by reading performance (Knoblauch et al., 1991). Color deficiencies can affect luminance contrast somewhat. Therefore, in the recommendation, the contrast is calculated in such a way that color is not a key factor so that people who have a color vision deficit will also have adequate contrast between the text and the background.

Proposed:

The intent of this Success Criterion is to provide enough luminance contrast between text and its background so that it can be read by people with moderately impaired contrast perception, without the use of contrast-enhancing assistive technology.

For people with Color Vision Deficiencies (CVD), often referred to as "color blindness", hue and saturation have minimal or no effect on legibility as assessed by reading performance (Knoblauch et al., 1991). Further, CVD per se, do not negatively affect luminance contrast perception (Márta Janáky et al., 2013; Cagri Ilhan et al., 2018). For people with color deficiencies, luminance contrast has a significant impact on legibility. Therefore, in the recommendation, contrast is calculated in such a way that color (hue) is not a key factor. People with other types of low vision also require strong contrast between text and its background for fluid reading.

@bruce-usab
Copy link
Contributor Author

Ping to @Myndex — I think additional information and detail about variants of 'color blindness' could/should be an addition issue/PR.

@Myndex
Copy link
Member

Myndex commented Jul 22, 2023

Hi @bruce-usab

This is good. I have a suggestion on the last couple sentences:

Instead of:

...For people with color deficiencies, luminance contrast has a significant impact on legibility. Therefore, in the recommendation, contrast is calculated in such a way that color (hue) is not a key factor. People with other types of low vision also require strong contrast between text and its background for fluid reading...

I would suggest:

... For all users of visual content, adequate luminance contrast is needed between text and its background for good readability. Many different visual impairments can substantially impact contrast sensitivity, requiring more luminance contrast, regardless of color (hue). Therefore, in the recommendation, contrast is calculated in such a way that color is not a key factor.


Errata:

In the second paragraph of the proposed:

...Further, CVD per se, do not negatively affect l...

should probably be

...Further, CVD per se, does not negatively affect l...


As for additions, I could see another PR to add in:

  1. Very saturated reds, oranges, blues, and purples are inherently low in luminance, and therefore should generally be the darkest of two colors.

  2. Some color-insensitive vision types see colors that have a substantial red component as visually much darker, emphasizing the importance of num 1.

  3. While readability relies on luminance contrast, essentially disregarding color(hue), this is not to say that color is not valuable for other visual tasks such as categorizing, object recognition, or differentiating lines on a map. Those with color-insensitive vision are at a disadvantage for tasks like these, see 1.4.1

@bruce-usab
Copy link
Contributor Author

Thanks @Myndex ! I took your suggestions, which made be realize I could replace with CVD with its definition.

Yes, I agree your 1/2/3 could/should be a separate issue and PR.

@bruce-usab
Copy link
Contributor Author

bruce-usab commented Jul 23, 2023

Current:

The intent of this Success Criterion is to provide enough contrast between text and its background so that it can be read by people with moderately low vision (who do not use contrast-enhancing assistive technology). For people without color deficiencies, hue and saturation have minimal or no effect on legibility as assessed by reading performance (Knoblauch et al., 1991). Color deficiencies can affect luminance contrast somewhat. Therefore, in the recommendation, the contrast is calculated in such a way that color is not a key factor so that people who have a color vision deficit will also have adequate contrast between the text and the background.

Proposed:

The intent of this Success Criterion is to provide enough luminance contrast between text and its background, so that it can be read by people with moderately low vision or impaired contrast perception, without the use of contrast-enhancing assistive technology.

For all consumers of visual content, adequate luminance contrast is needed between text and its background for good readability. Many different visual impairments can substantially impact contrast sensitivity, requiring more luminance contrast, regardless of color (hue). For people who are not able to distinguish certain shades of color — often referred to as color blindness — hue and saturation have minimal or no effect on legibility as assessed by reading performance (Knoblauch et al., 1991). Further, the inability to distinguish certain shades of color does not negatively affect luminance contrast perception (Márta Janáky et al., 2013; Cagri Ilhan et al., 2018). Therefore, in the recommendation, contrast is calculated in such a way that color (hue) is not a key factor.

@Myndex
Copy link
Member

Myndex commented Jul 23, 2023

Yes, I agree your 1/2/3 could/should be a separate issue and PR.

Thank you @bruce-usab … do you think these adds should be inside a green “note” or just a couple paragraphs?

@bruce-usab
Copy link
Contributor Author

@Myndex -- I don't think Understanding uses green notes. So I think the information can be added as stand-alone paragraph(s).

@bruce-usab
Copy link
Contributor Author

bruce-usab commented Jul 26, 2023

Today I inserted low vision or into intent sentence of this PR, in response to issue comment from @GreggVan.

@GreggVan
Copy link

GreggVan commented Aug 22, 2023 via email

@bruce-usab
Copy link
Contributor Author

@mbgower I concur with all your edits. But I am not clear if that means I should be clicking "resolved conversation" or not. That caused trouble last time I tried to use the feature.

  1. On the call/survey you noted that recent changes were duplicative of some sentences further down the page. I did not track that observation, but maybe delete the redundant parts? Seems like lightweight noncontroversial editorial.
  2. Also on the call/survey you noted that the in-line references (and hyperlinks) was a unique treatment. I agree. But I do not think they belong in the "Related Resources". I considered adding new section, References, and listing the citations there. Do we have other Understanding docs with that sort of category grouping? This might be better addressed in a separate issue/PR.

22/08/2023

Co-authored-by: Mike Gower <mikegower@gmail.com>
@alastc
Copy link
Contributor

alastc commented Aug 23, 2023

I've accepted Michael's edits whcih resolves the conversations. I also added preview in the description.

@alastc
Copy link
Contributor

alastc commented Aug 23, 2023

2. Also on the call/survey you noted that the in-line references (and hyperlinks) was a unique treatment.  I agree.  But I do _not_ think they belong in the "Related Resources".  

Hi Bruce, are you sure? I applied that change (before reading this comment!) and it seems ok to me. In the resources listing it is easier to spell out the full title of the research. I don't think leaving it in the main text (with titles attributes for the title of the research!) is a good way of including them.

We could probably hack in some within-page (footer style) links to attach the resources to that place in the text.

@bruce-usab
Copy link
Contributor Author

@alastc I am okay with whatever treatment for the citations.

I made them hypertext links because they were much more academic than any of our other "Related Resources" which tend to practical utility. AFAIK we do not elsewhere use links under Related Resources to justify specific assertions in Understanding.

@alastc alastc merged commit 3698095 into main Aug 29, 2023
@fstrr fstrr deleted the Issue2033-Contrast-Minimum-Understanding branch May 23, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Understanding for Contrast does not call out Color Blindness
6 participants