Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech drag drop cancel #456

Merged
merged 18 commits into from
Apr 26, 2019
Merged

Tech drag drop cancel #456

merged 18 commits into from
Apr 26, 2019

Conversation

detlevhfischer
Copy link
Contributor

@detlevhfischer detlevhfischer commented Aug 21, 2018

@detlevhfischer detlevhfischer added Ready for initial review A new technique ready for +1s or itterations Techniques labels Aug 21, 2018
@alastc
Copy link
Contributor

alastc commented Sep 4, 2018

Hi Detlev,

Presumably this is to support 2.5.2? Particularly "Completion of the function is on the up-event, and a mechanism is available to abort the function before completion or to undo the function after completion;"

A few little points:

  • I think the description should be first, I found the UA support notes a little confusing to start with, it made sense after I'd read the objective. It might even be a sub-section of the Description?
  • There's an extra left-bracken in the Resources H2 closing tag.
  • In the procedure, rather than step one I'd put it in a paragraph above the llist, and say:

"For content which is draggable check whether:"

  1. The drag-and-drop action can be reversed by releasing the picked-up item outside a drop target
  2. The drag-and-drop action can be reversed by dragging the picked-up item back to its old position.
  3. The drag-and-drop action can be reversed after releasing the item over the drop target via a dialog or an undo control.

Expected Results
Any of #2, #3, or #4 are true

I suspect someone will say "this isn't a technique, it is a test procedure", but I can't think how to convert it to be a more specific technique at the moment :-/

@mbgower
Copy link
Contributor

mbgower commented Oct 16, 2018

typo: us for is, first line

detlevhfischer and others added 7 commits October 18, 2018 16:49
After the explicit exclusion of draf-n-drop actions from the scope of SC 2.5.1 Pointer Gestures, it seemed wise to rename this technique from "Ensuring that drag-and-drop gestures can be cancelled" to "Ensuring that drag-and-drop actions can be cancelled" to avoid confusion.

It seemed difficult, however, to remove every mention of 'gesture', for example, in the User Agent and Assistive Technology Support Notes: "On touch screen devices, author-supplied path-based and multipoint gestures usually do not work when OS level assistive technologies (AT) like a built-in screenreader is turned on." - Is it confusing to talk about "path-based and multipoint actions" rather than gestures? I am not sure how to best remove the wobbliness of this...
Made ‘item’ consistent as the thing being picked up.
@alastc alastc added Ready for WG Review and removed Ready for initial review A new technique ready for +1s or itterations labels Nov 20, 2018
@alastc
Copy link
Contributor

alastc commented Nov 29, 2018

@detlevhfischer I think this is a sufficient technique for pointer cancellation, but I have to admit it took a lot of thought to get there, is that right?
@michael-n-cooper another one ready, including an update to the technique listing in the understanding doc.

@michael-n-cooper
Copy link
Member

I didn't review this because it was closed after requesting my review. If this was approved by the WG, it should be reopened and whatever fixes needed made.

@alastc alastc reopened this Nov 30, 2018
@alastc
Copy link
Contributor

alastc commented Nov 30, 2018

This was approved on the call, not sure why Detlev closed it. I was just checking that I had targeted the correct SC.

@mbgower
Copy link
Contributor

mbgower commented Dec 20, 2018

For content which is draggable check whether:

Can't review the whole file at the moment, so I'll just note that a concern I have with this phrase is that some things are draggable which I might not classify as drag and drop. For instance, a slider is draggable. However, I haven't seen anyone implement a cancel function on a slider. To me, that would be pretty intrusive (given the drag is a change of value on a continuum and it is just a matter of repositioning it).

Was clashing with published 207 for icon contrast.
@alastc
Copy link
Contributor

alastc commented Dec 20, 2018

Just corrected a clashing filename, it can be previwered here now:
http://htmlpreview.github.io/?https://github.com/w3c/wcag/blob/tech-drag-drop-cancel/techniques/general/G208.html

Copy link
Member

@michael-n-cooper michael-n-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure of the technique looks ok.

I'm concerned about the links in the Understanding doc to M029 and FM001. Those are not approved techniques, and the first issue is people might follow the links and not know the difference. Further, the naming pattern makes the generator think they are official techniques and try to process them as such, which will create problems since corresponding files (in the suite) don't exist. I recently expanded the ability of the generator to recognize technique filename patterns, but that means these techniques are getting swept into the recognition. We can't have it both ways, liberal recognition and exclusion of things that are deliberately made overly similar.

We need either a decision that no links in Understanding techniques sections are allowed except to approved techniques, or agree on parameters for such links that will avoid accidental inclusion in the generator and confusion with readers. Until that's sorted, I can't approve this merge.

@alastc
Copy link
Contributor

alastc commented Jan 11, 2019

Good point, I had left those in for reference, but I've moved the references into the spreadsheet and removed the links.

@awkawk awkawk merged commit b643ce6 into master Apr 26, 2019
@awkawk awkawk deleted the tech-drag-drop-cancel branch April 26, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants