Add permissions policy check for FedCM #204
Conversation
Companion change to w3c-fedid/FedCM#236
index.bs
Outdated
| @@ -947,6 +950,12 @@ spec:css-syntax-3; | |||
| 1. Let |sameOriginWithAncestors| be `true` if |settings| is [=same-origin with its | |||
| ancestors=], and `false` otherwise. | |||
|
|
|||
| 1. If |options|[{{CredentialRequestOptions/identity}}] [=map/exists=] then | |||
| if |settings|' [=relevant global object=]'s [=associated Document=] is **not** | |||
| [=allowed to use=] the "fedcm" | |||
There was a problem hiding this comment.
Can we link the "fedcm" feature policy to a definition on the fedcm spec?
There was a problem hiding this comment.
I think so, I can give it a shot.
index.bs
Outdated
| @@ -947,6 +950,12 @@ spec:css-syntax-3; | |||
| 1. Let |sameOriginWithAncestors| be `true` if |settings| is [=same-origin with its | |||
| ancestors=], and `false` otherwise. | |||
|
|
|||
| 1. If |options|[{{CredentialRequestOptions/identity}}] [=map/exists=] then | |||
| if |settings|' [=relevant global object=]'s [=associated Document=] is **not** | |||
| [=allowed to use=] the "fedcm" | |||
There was a problem hiding this comment.
Per my comment on the other PR, let's rename the value to something different from fedcm.
There was a problem hiding this comment.
Now that we've settled on a new name on the other PR, I'll update this one as well.
| type: interface | ||
| text: IdentityCredential; url: identitycredential | ||
| type: dict-member |
There was a problem hiding this comment.
I guess we should export these from FedCM so they can automagically be used here... but this is fine for now.
There was a problem hiding this comment.
Yeah, I'm curious why they don't get picked up, I tried exporting the PP name. The spec works for now, but I'll ask someone wiser than me what we're doing wrong here..
There was a problem hiding this comment.
Talked to wise sage @tabatkins who will add FedCM to the spec database for us(in a grand ceremony, I expect). That should fix this.
Thank you, Tab!
There was a problem hiding this comment.
Added now, give the database an hour or so for the next run to pick up the definitions.
SHA: 05f4402 Reason: push, by @johannhof Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Companion change to w3c-fedid/FedCM#236
Preview | Diff