Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publickey-credentials-create permission policy #209

Merged

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Sep 14, 2022

This PR adds support for publickey-credentials-create permission policy,
to support w3c/webauthn#1801

See also w3c/webauthn#1656


Preview | Diff

@stephenmcgruer
Copy link
Contributor Author

(I believe the build fails because the corresponding WebAuthn PR is not landed, so the dfn reference isn't there yet)

@stephenmcgruer
Copy link
Contributor Author

cc @ve7jtb , who I believe wished to make sure that this was compatible with the previous L2 discussion on what create() in a cross-origin iframe would look like (particularly the permission policy name, I believe).

@johannhof johannhof requested a review from nsatragno September 26, 2022 07:21
index.bs Outdated Show resolved Hide resolved
@stephenmcgruer stephenmcgruer force-pushed the smcgruer/publickey-credentials-create branch from 5453b61 to 305097c Compare September 26, 2022 11:52
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for the webauthn PR to be merged before merging this one.

@aaahlam621997
Copy link

يضيف هذا PR دعما لسياسة الأذونات ، لدعم w3c / webauthn # 1801publickey-credentials-create

انظر أيضا w3c/webauthn#1656

معاينة | فرق

@stephenmcgruer
Copy link
Contributor Author

(Closing/opening just to kick the CI into re-running)

@stephenmcgruer
Copy link
Contributor Author

So the CI is broken because the navigation re-write in HTML (whatwg/html#6315) un-exported the concept of a parent browsing context, and so the entire webappsec-credential-management spec will no longer build. Guidance from HTML folks is that the spec should be talking in terms of Navigables instead of browsing contexts, which I don't immediately understand very well 🤣

This is not related to this PR, so my suggestion is that we ignore the failing CI here and open an issue to track the failing build - wdyt @nsatragno ?

@nsatragno
Copy link
Member

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants