-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publickey-credentials-create permission policy #209
Add support for publickey-credentials-create permission policy #209
Conversation
(I believe the build fails because the corresponding WebAuthn PR is not landed, so the dfn reference isn't there yet) |
cc @ve7jtb , who I believe wished to make sure that this was compatible with the previous L2 discussion on what create() in a cross-origin iframe would look like (particularly the permission policy name, I believe). |
Co-authored-by: Johann Hofmann <mail@johann-hofmann.com>
5453b61
to
305097c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's wait for the webauthn PR to be merged before merging this one.
|
(Closing/opening just to kick the CI into re-running) |
So the CI is broken because the navigation re-write in HTML (whatwg/html#6315) un-exported the concept of a This is not related to this PR, so my suggestion is that we ignore the failing CI here and open an issue to track the failing build - wdyt @nsatragno ? |
SGTM |
This PR adds support for
publickey-credentials-create
permission policy,to support w3c/webauthn#1801
See also w3c/webauthn#1656
Preview | Diff