Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the "attestation" of a WebAuthnAttestation be a non-object? #289

Closed
bzbarsky opened this issue Nov 4, 2016 · 5 comments
Closed

Can the "attestation" of a WebAuthnAttestation be a non-object? #289

bzbarsky opened this issue Nov 4, 2016 · 5 comments
Labels
type:technical
Milestone
WD-04

Comments

@bzbarsky
Copy link

bzbarsky commented Nov 4, 2016

Right now this attribute is specified to be any, but are there situations in which it's not an object?
@equalsJeffH
Copy link
Contributor

Instead of any might we declare it object (that would be correct idl-wise?) ?

@equalsJeffH equalsJeffH added this to the WD-04 milestone Nov 7, 2016
@bzbarsky
Copy link
Author

bzbarsky commented Nov 7, 2016

object would be correct if it's always guaranteed to be an object, yes.

@vijaybh
Copy link
Contributor

vijaybh commented Nov 7, 2016

This should be addressed by #244 which aims to make attestation an ArrayBuffer.

@AngeloKai
Copy link
Contributor

AngeloKai commented Nov 16, 2016 •
edited
Loading

Since #244 already address the issue, can we mark this issue as closed?

@equalsJeffH
Copy link
Contributor

we will close this by reference in a commit message related to an actual change in the spec that addresses this. that's been our working practice.

vijaybh added a commit that referenced this issue Jan 11, 2017
@vijaybh
Proofreading fixes, finish attestation cleanup
03cf327 
Fixed small wording and markdown issues. This completes the changes to
make attestation opaque to UAs, which fixes #286, fixes #287, and fixes
#289. It also fixes #239 by removing the homegrown algorithm identifiers
and specifying the algorithm explicitly in attestation data using JWK
identifiers. It also fixes #240 by encoding keys in CBOR which specifies
lengths of fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:technical
Projects
None yet
Milestone
WD-04
Development

No branches or pull requests
4 participants
@equalsJeffH @bzbarsky @AngeloKai @vijaybh