Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVM Extension Editorial Change #368

Closed
apowers313 opened this issue Mar 1, 2017 · 6 comments
Closed

UVM Extension Editorial Change #368

apowers313 opened this issue Mar 1, 2017 · 6 comments

Comments

@apowers313
Copy link
Contributor

The UVM Extension text currently includes the following:

Authenticator processing
The authenticator augments the authenticator data with a user verification index indicating the method used by the user to authorize the operation, as defined below. This extension can be added to attestation objects and assertions.

Note the mention of user verification index, which was probably copied from the UVI extension. I'm not sure if the fix is as simple as changing index to mode or if the whole section should be re-written.

@selfissued
Copy link
Contributor

Note that PR #389 changed "mode" to "method", fixing issue #411 . I understand that this doesn't address the confusion between "index" and "method". The owner of this extension ( @rlin1 ?) should review the text and propose a fix.

@equalsJeffH
Copy link
Contributor

good catch @apowers313, thx.

I propose this fix:
The [=authenticator=] sets the [=authenticator extension output=] to be a uvmFormat structure indicating (any or all of) the user verification method employed for the [=authorization gesture=], the [=authenticator=]'s key protection type and/or matcher protection type.

[ I am now guessing that @rlin1 had named this extension "user verification mode" (rather than UV "method") because it can convey more information that just the UV Method employed. ]

@selfissued
Copy link
Contributor

Sounds fine to me

@nadalin
Copy link
Contributor

nadalin commented Sep 6, 2017

@selfissued @rlin1 please create a PR and merge

@rlin1
Copy link
Contributor

rlin1 commented Nov 9, 2017

see #675

@rlin1 rlin1 mentioned this issue Nov 9, 2017
@equalsJeffH equalsJeffH self-assigned this Nov 29, 2017
@equalsJeffH
Copy link
Contributor

this was fixed by PR #675 as noted by @rlin1 #368 (comment). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants