Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attObj and Figure 3 [[#fig-attStructs]] do not agree #401

Closed
equalsJeffH opened this issue Apr 13, 2017 · 3 comments · Fixed by #426
Closed

attObj and Figure 3 [[#fig-attStructs]] do not agree #401

equalsJeffH opened this issue Apr 13, 2017 · 3 comments · Fixed by #426

Comments

@equalsJeffH
Copy link
Contributor

in 5.3.4. Generating an Attestation Object, we have this CDDL description:

attObj = {
            authData: bytes,
            $$attStmtType
         }

attStmtTemplate = (
                      fmt: text,
                      attStmt: bytes
                  )

; Every attestation statement format must have the above fields
attStmtTemplate .within $$attStmtType

Tho, in Figure 3, the Attestation Object is illustrated (in part) as having this core structure:

ATTESTATION OBJECT
                     [ "fmt": "packed", ... | "authData": ... | "attStmt": ...  ]

If nothing in the rest of the spec is depending upon the ordering illustrated in Figure 3, then perhaps, if I am correct that this is an issue, we can just adjust Figure 3 to reflect reality?

A cursory look thru the rest of the spec seems to indicate that we can just repair Figure 3 to be something like:

ATTESTATION OBJECT
                     [  "authData": ... |  "fmt": "packed"  |  "attStmt": ... ]
@vijaybh
Copy link
Contributor

vijaybh commented Apr 14, 2017

+1, I had meant to make this change as part of the CDDL PR and just forgot.

@equalsJeffH
Copy link
Contributor Author

there's also some other things in that figure that are messed up, eg "credential ID" and "credential public key" overrunning each other up in the so-called attestation data object. see also #393.

equalsJeffH pushed a commit that referenced this issue Apr 25, 2017
@selfissued
Copy link
Contributor

Let's get this fix in for WD-05. There's no reason not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants