Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[Create]] and [[DiscoverFromExternalSource]] references have inconsistent parameter lists #701

Closed
equalsJeffH opened this issue Nov 28, 2017 · 0 comments
Closed

[[Create]] and [[DiscoverFromExternalSource]] references have inconsistent parameter lists #701

equalsJeffH opened this issue Nov 28, 2017 · 0 comments
Assignees
@equalsJeffH
Labels
stat:pr-open type:editorial
Milestone
WD-07

Comments

@equalsJeffH
Copy link
Contributor

we do not consistenly denote the param lists of [[Create]] and [[DiscoverFromExternalSource]]. they all should at this time be (origin, options) (rather than just (options), as some are now).

Note that we also need to consistently add a sameOriginWithAncestors param (see #700).
@equalsJeffH equalsJeffH mentioned this issue Nov 28, 2017
Closed
equalsJeffH pushed a commit that referenced this issue Nov 28, 2017
fix #700 add sameOriginWithAncestors parameter to internal methods, i…
c955f00 
…mprove #701
equalsJeffH pushed a commit that referenced this issue Nov 28, 2017
fix #701 [[Create]] and [[DiscoverFromExternalSource]] references hav…
44c0e22 
…e inconsistent parameter lists
@equalsJeffH equalsJeffH mentioned this issue Nov 28, 2017
Merged
@equalsJeffH equalsJeffH self-assigned this Nov 29, 2017
@equalsJeffH equalsJeffH added this to the WD-07 milestone Nov 29, 2017
WebAuthnBot pushed a commit that referenced this issue Nov 30, 2017
Built by Travis-CI: 2f0b13e fix #700 & #701: add same origin with anc…
a4c0d67 
…estors param (#702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@equalsJeffH equalsJeffH

Labels
stat:pr-open type:editorial
Projects
None yet
Milestone
WD-07
Development

No branches or pull requests
1 participant
@equalsJeffH