Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolf attestation types 121 #138

Merged
merged 7 commits into from
Jul 13, 2016
Merged

Rolf attestation types 121 #138

merged 7 commits into from
Jul 13, 2016

Conversation

rlin1
Copy link
Contributor

@rlin1 rlin1 commented Jul 3, 2016

please review

@bifurcation
Copy link
Contributor

This looks fine to me, just a minor terminology fix.

@vijaybh
Copy link
Contributor

vijaybh commented Jul 6, 2016

LGTM

@equalsJeffH
Copy link
Contributor

ah, so this fixes #121 -- LGTM overall -- this seems like more understandable terminology to me. see also #141

@apowers313
Copy link
Contributor

Also partially fixes #88

@rlin1 rlin1 merged commit a6695b2 into master Jul 13, 2016
WebAuthnBot pushed a commit that referenced this pull request Jul 13, 2016
@vijaybh vijaybh deleted the rolf-attestation-types-121 branch July 13, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants