Deprecate rp.name #2159
Merged
Deprecate rp.name #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl
reviewed
Oct 2, 2024
MasterKale
approved these changes
Oct 2, 2024
Co-authored-by: Adam Langley <agl@google.com>
agl
reviewed
Oct 2, 2024
| - This string MAY contain language and direction metadata. [=[RPS]=] SHOULD consider providing this information. See [[#sctn-strings-langdir]] about how this metadata is encoded. | ||
| - This string MAY contain language and direction metadata. | ||
| [=[RPS]=] SHOULD consider providing this information if setting the member to a value other than the [=RP ID=]. | ||
| See [[#sctn-strings-langdir]] about how this metadata is encoded. |
There was a problem hiding this comment.
Aren't we getting rid of this stuff? Wasn't that the outcome from TPAC?
There was a problem hiding this comment.
I figure we're tracking that aspect in #1643, this PR simply preserves what's currently there (but aligns it with the suggested default).
sbweeden
approved these changes
Oct 3, 2024
|
Per discussion on WG call 2024-10-02, merging this as I was asked to be a secondary reviewer and there were no objections to merging after that review. |
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2024
SHA: 1e2256d Reason: push, by sbweeden Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2121.
The following tasks have been completed:
[ ] Modified Web platform tests (link)No change to client logicImplementation commitment:
[ ] WebKit (link to issue)[ ] Chromium (link to issue)[ ] Gecko (link to issue)Documentation and checks
[ ] Affects privacy[ ] Affects security[ ] Updated explainer (linkPreview | Diff