Fix up several linking mistakes. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
force-pushed
the
fix-refs
branch
2 times, most recently
from
849dd4d
to
f88519d
Compare
jyasskin
commented
Feb 13, 2017
index.bs
Outdated
| @@ -39,28 +39,22 @@ Markup Shorthands: css off, markdown on | |||
|
|
|||
| <pre class="anchors"> | |||
|
|
|||
| <!-- spec: HTML; urlPrefix: https://html.spec.whatwg.org/multipage/ --> | |||
| spec: HTML51; urlPrefix: http://www.w3.org/TR/html51/; for: web | |||
| spec: HTML; urlPrefix: https://html.spec.whatwg.org/multipage/ | |||
There was a problem hiding this comment.
I could also switch this to HTML52 and https://w3c.github.io/html/. IMO, it's not quite as good as the WHATWG's version, but it fixes many mistakes in HTML5.1, which will save folks time reading your crosslinks.
jyasskin
force-pushed
the
fix-refs
branch
6 times, most recently
from
2829c06
to
d946ac4
Compare
equalsJeffH
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
I only have one minor question, otherwise the LGTM, thanks @jyasskin :)
index.bs
Outdated
| @@ -690,7 +694,7 @@ authorizing an authenticator with which to complete the operation. | |||
| }; | |||
| </pre> | |||
|
|
|||
| <div dfn-for="Attachment"> | |||
| <div> | |||
There was a problem hiding this comment.
am curious why this is an unadorned <div> ?
There was a problem hiding this comment.
No good reason; I just missed that I should remove it once it didn't have a dfn-for. I've pushed a new commit that removes it. Thanks!
jcjones
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.