-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert makeCredential()
's parameters into a dictionary.
#399
Merged
Commits on Apr 12, 2017
-
Introduce authenticator response interfaces.
This patch adds an 'AuthenticatorResponse' interface, representing the generic attributes of responses from authenticators. It then redefines 'ScopedCredentialInfo' and 'AuthenticatorAssertion' to derive from this interface, and renames them to 'AuthenticatorAttestionResponse' and 'AuthenticatorAssertionResponse' respectively. These new interfaces are a drop-in replacement for the old interfaces, no normative changes are intended in this patch, other than the renaming.
Configuration menu - View commit details
-
Copy full SHA for 2d10a10 - Browse repository at this point
Copy the full SHA 2d10a10View commit details -
Move
getAssertion()
'schallenge
intoAssertionOptions
Passing a single dictionary parameter into `getAssertion()` provides for greater forward compatibility, as new data can be flexibly added to the method invocation without restructuring the existing structure. It also helps developers understand what they're passing in. This is less important for `getAssertion()` than it is for `makeCredential()`, obviously, but aligning both in a similar structure seems like a good change to make.
Configuration menu - View commit details
-
Copy full SHA for a9da992 - Browse repository at this point
Copy the full SHA a9da992View commit details -
Convert
makeCredential()
's parameters into a dictionary.Passing a single dictionary parameter into `makrCredential()` provides for greater forward compatibility, as new data can be flexibly added to the method invocation without restructuring the existing structure. It also helps developers understand what they're passing in, as each parameter will be labeled. This patch restructures the data passed into `makeCredential()` substantially, moving from four parameters to a single dictionary, and merging some existing types into a simpler structure. Most of it is straightforward; the only bit I know will be controversial is dropping `RelyingPartyUserInfo` in favor of two instances of a simpler `ScopedCredentialEntity` object: one for the RP, one for the user. Let's chat about how (un)reasonable this approach might be.
Configuration menu - View commit details
-
Copy full SHA for 4fad3e5 - Browse repository at this point
Copy the full SHA 4fad3e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0039a13 - Browse repository at this point
Copy the full SHA 0039a13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dca154 - Browse repository at this point
Copy the full SHA 6dca154View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a5fefb - Browse repository at this point
Copy the full SHA 3a5fefbView commit details
Commits on Apr 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3cdf1bf - Browse repository at this point
Copy the full SHA 3cdf1bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f4b79f - Browse repository at this point
Copy the full SHA 4f4b79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 705ecab - Browse repository at this point
Copy the full SHA 705ecabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8058917 - Browse repository at this point
Copy the full SHA 8058917View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae33b14 - Browse repository at this point
Copy the full SHA ae33b14View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.