-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe how authenticators unique and find credential sources. #623
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fb72770
Define Public Key Credential Source and Credential ID.
jyasskin bade774
Link "credential ID".
jyasskin 493dd3c
Allow hashes as credential IDs.
jyasskin 50d8d1b
Describe how authenticators unique and find credential sources.
jyasskin 257b3d6
first pass merge-from-upstream-master-and-fix-conflicts
50528aa
Merge branch 'master' into put-credentials-in-a-map
bda9ba8
finish merge-from-master and fixup dangling internal crossrefs
31efa65
restore masthead
69a7a14
restore clientDataHash rather than tbsHash in U2F attstn format
e7a1d2b
fixing rendering issue
5f47c4c
fixup merge-from-master loose ends by hand
5254ef9
fix var ignore issue
f46d5de
Merge branch 'master' into put-credentials-in-a-map
546398e
Merge branch 'master' into put-credentials-in-a-map
48de8b2
address emlun's comments, thx!
1a9ccb3
catch straggler from emlun's comments, mea culpa
369202a
ignore a var make bikeshed happier
dc50b3f
move op-lookup-credsource-by-credid alg to new subsection
14335b1
dont need ignore no more
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CTAP stores the user handle only for client-side-resident private key credentials, so it seems misleading to imply that it must always be returned (unless we point out at the definition site that the
userHandle
field is nullable). See also the client's getAssertion method.